add plugin cve-2021-21985 #61

hh-hunter · 2021-09-29T10:41:01Z

No description provided.

google-cla · 2021-09-29T10:41:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

hh-hunter · 2021-09-29T10:42:24Z

@googlebot I signed it!

h0ng10

Hello
I did a quick check of the plugin, seems like there are some smaller bugs due to copy/paste

h0ng10 · 2021-10-01T06:07:47Z

...in/java/com/google/tsunami/plugins/detectors/cves/cve202121985/CVE202121985VulnDetector.java

+		type = PluginType.VULN_DETECTION,
+		name = "CVE-2021-21985",
+		version = "0.1",
+		description = "Spring Boot Actuator Logview Arbitrary file reading",


This description is wrong, seems like a copy / paste error

Should be something like "vSphere Client (HTML5) contains a remote code execution vulnerability due to lack of input validation in the Virtual SAN Health Check plug-in"

h0ng10 · 2021-10-01T06:08:29Z

...in/java/com/google/tsunami/plugins/detectors/cves/cve202121985/CVE202121985VulnDetector.java

+	@Override
+	public DetectionReportList detect(
+			TargetInfo targetInfo, ImmutableList<NetworkService> matchedServices) {
+		logger.atInfo().log("CVE-2021-21234 starts detecting.");


CVE-Number (CVE-2021-21234) is wrong

hh-hunter · 2021-10-01T12:42:22Z

@h0ng10 i have resubmitted it once and fixed the two problems you mentioned.

lokiuox · 2024-11-28T17:09:25Z

Hi @hh-hunter, thank you for your contribution! Can you please submit a testbed for this detector in the https://github.com/google/security-testbeds repo?

hh-hunter · 2024-11-29T03:15:48Z

@lokiuox I see that the related issue is closed. Should I continue to submit this? And is there a bonus involved?
#50

tooryx · 2024-11-29T07:30:42Z

Hi @hh-hunter,

There is a bunch of PRs that were lingering around for a while. I don't think they were ever accepted in the PRP, but given that you were a good contributor over the years, there will probably be a group bonus for all of these requests.

~tooryx

hh-hunter · 2024-12-05T06:25:23Z

Hi @hh-hunter,

There is a bunch of PRs that were lingering around for a while. I don't think they were ever accepted in the PRP, but given that you were a good contributor over the years, there will probably be a group bonus for all of these requests.

~tooryx

Okay, I will devote some time to deal with this matter in the near future

ikkisoft · 2025-01-30T13:44:44Z

@hh-hunter We're trying to cleanup all open tickets, and it appears that the following PRs are waiting on you to provide the testbeds (which are now required and mandatory):

#90 add plugin cve-2019-17382
#83 add plugin cve-2019-15107
#81 add plugin cve-2019-19781
#78 add plugin cve-2021-21978
#76 add plugin cve-2021-1497
#75 add plugin cve-2021-24499
#74 add plugin cve-2021-21234
#73 add plugin cve-2021-39316
#61 add plugin cve-2021-21985

Please let us know if you plan to work on those. Thanks!

hh-hunter · 2025-01-31T01:08:51Z

@hh-hunter We're trying to cleanup all open tickets, and it appears that the following PRs are waiting on you to provide the testbeds (which are now required and mandatory):

#90 add plugin cve-2019-17382 #83 add plugin cve-2019-15107 #81 add plugin cve-2019-19781 #78 add plugin cve-2021-21978 #76 add plugin cve-2021-1497 #75 add plugin cve-2021-24499 #74 add plugin cve-2021-21234 #73 add plugin cve-2021-39316 #61 add plugin cve-2021-21985

Please let us know if you plan to work on those. Thanks!

I am working on completing these issues, and since I am on vacation now, the response may be slow.Some topics are too old. When I submitted this, I submitted the relevant environment in my warehouse. You can use this environment for testing first. I will migrate to google/security-testbeds later. Thank you for your understanding.

hh-hunter · 2025-02-06T07:15:13Z

@ikkisoft I have submitted the environment for CVE-2019-15107, google/security-testbeds#118 and I am gradually starting on the others. Please let me know if you still need anything, otherwise I will prioritize other PRs with rewards. Most of these earlier PRs have already been closed, it seems like you only need to submit the environment.

ikkisoft · 2025-02-06T09:51:40Z

@hh-hunter Great. We will start reviewing that one so that we can slowly catch up with all. We have a few resources allocate to this so it should speed up the overall reviews. Thanks again for your contributions!

hh-hunter · 2025-02-07T06:46:54Z

@ikkisoft I have just solved a new environment. google/security-testbeds#119 ，and i noticed that some PRs do not have an environment for testing deployment on Docker or k8s, unless they use a virtual machine like the other one. Or use a similar honeypot as an alternative, how should I proceed?

cve-2019-19781 is Citrix Application Delivery Controller,without container environment, but with a similar honeypot environment.
cve-2021-21978, The VM official website no longer has this product, and it may not be possible to download it due to the environment.
cve-2021-1497 , Too long, the official website can no longer download the historical versions with vulnerabilities.and he doesn't have a containerized version.
cve-2021-24499, WordPress theme has a vulnerability, I am preparing this environment next
cve-2021-21234, SpringBoot vulnerabilities, I am preparing this environment next
cve-2021-39316, WordPress plugin zoomsounds has a vulnerability, I am preparing this environment next
cve-2021-21985, You must install a specific version of VMware Center; there is no containerized version.

I will prepare to perfect the environment for cve-2021-24499, cve-2021-21234, and cve-2021-39316 next. For the others, due to some issues, I don't know how to start. If you have better suggestions, please let me know.

ikkisoft · 2025-02-07T14:02:02Z

Whenever possible, you should provide a docker container. If there is no containerized version, but you can make one (e.g. OSS product), we expect contributors to build the container.

For proprietary software with no containerized version, we expect a detailed README with instructions on how to setup the vulnerable / not-vulnerable testbed. This is required as we need to verify the correct operation of the plugin.

Regarding old software, we expect a reasonable effort to attempt to find the correct version using mirrors and other websites. Without a testbed, we might not be able to accept the contribution.

hh-hunter · 2025-02-08T06:43:53Z

Whenever possible, you should provide a docker container. If there is no containerized version, but you can make one (e.g. OSS product), we expect contributors to build the container.

For proprietary software with no containerized version, we expect a detailed README with instructions on how to setup the vulnerable / not-vulnerable testbed. This is required as we need to verify the correct operation of the plugin.

Regarding old software, we expect a reasonable effort to attempt to find the correct version using mirrors and other websites. Without a testbed, we might not be able to accept the contribution.

I understand that I will prioritize solving those related to open source and container environments. The rest, I will contact you as the situation arises, as many are outdated and the current internet is not fully open. I cannot guarantee that the installation packages can still be obtained now, but they were definitely accessible at that time.

hh-hunter · 2025-02-08T06:45:20Z

@ikkisoft

cve-2021-24499 add CVE-2019-17382 in the security-testbeds environment security-testbeds#119
cve-2021-39316 add CVE-2021-39316 in the security-testbeds environment security-testbeds#122
These two have been made.

tooryx · 2025-07-04T12:25:15Z

Hi @hh-hunter,

I will close this PR. Unfortunately the testbed is not available anymore and setting up the environment to reproduce it it too time consuming.

We will prioritize your other contributions.
~tooryx

add plugin cve-2021-21985

425911e

google-cla bot added the cla: no label Sep 29, 2021

google-cla bot added cla: yes and removed cla: no labels Sep 29, 2021

hh-hunter added 4 commits September 30, 2021 10:21

change publisher is TSUNAMI_COMMUNITY

593a41b

Change paylaod to use predefined variables

439e047

change packages and move folder

a1f69c8

change vul severity

300e87a

h0ng10 suggested changes Oct 1, 2021

View reviewed changes

fix: fix wrong log info and description

5ae0ae4

hh-hunter added 2 commits October 4, 2021 17:29

Merge branch 'google:master' into addPlugin/cve202122985

dbdfcd3

Merge branch 'google:master' into addPlugin/cve202122985

1e3a222

tooryx added the Contributor queue When a contributor has already one issue/PR in review, we put the following ones on hold with this. label Feb 1, 2024

tooryx assigned hh-hunter Jul 17, 2024

tooryx closed this Jul 4, 2025

add plugin cve-2021-21985 #61

add plugin cve-2021-21985 #61

Uh oh!

Conversation

hh-hunter commented Sep 29, 2021

Uh oh!

google-cla bot commented Sep 29, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

hh-hunter commented Sep 29, 2021

Uh oh!

h0ng10 left a comment

Choose a reason for hiding this comment

Uh oh!

h0ng10 Oct 1, 2021

Choose a reason for hiding this comment

Uh oh!

h0ng10 Oct 1, 2021

Choose a reason for hiding this comment

Uh oh!

h0ng10 Oct 1, 2021

Choose a reason for hiding this comment

Uh oh!

hh-hunter commented Oct 1, 2021

Uh oh!

lokiuox commented Nov 28, 2024

Uh oh!

hh-hunter commented Nov 29, 2024

Uh oh!

tooryx commented Nov 29, 2024

Uh oh!

hh-hunter commented Dec 5, 2024

Uh oh!

ikkisoft commented Jan 30, 2025

Uh oh!

hh-hunter commented Jan 31, 2025

Uh oh!

hh-hunter commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikkisoft commented Feb 6, 2025

Uh oh!

hh-hunter commented Feb 7, 2025

Uh oh!

ikkisoft commented Feb 7, 2025

Uh oh!

hh-hunter commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hh-hunter commented Feb 8, 2025

Uh oh!

tooryx commented Jul 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hh-hunter commented Feb 6, 2025 •

edited

Loading

hh-hunter commented Feb 8, 2025 •

edited

Loading