fix(tool): fix mypy errors using cast and schema corrections

Author: anubhav756

packages/toolbox-adk/src/toolbox_adk/tool.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from typing import Any, Awaitable, Callable, Dict, Optional
+from typing import Any, Awaitable, Callable, Dict, Optional, cast
 
 import toolbox_core
 from fastapi.openapi.models import (
@@ -127,38 +127,28 @@ async def run_async(
                     oauth2=OAuth2Auth(
                         client_id=self._auth_config.client_id,
                         client_secret=self._auth_config.client_secret,
-                        scopes=scopes,
                     ),
                 ),
             )
 
             # Check if we already have credentials from a previous exchange
             try:
                 # get_auth_response returns AuthCredential if found
-                creds = tool_context.get_auth_response(auth_config_adk)
+                ctx_any = cast(Any, tool_context)
+                creds = ctx_any.get_auth_response(auth_config_adk)
                 if creds and creds.oauth2 and creds.oauth2.access_token:
                     reset_token = USER_TOKEN_CONTEXT_VAR.set(creds.oauth2.access_token)
                 else:
-                    # Request credentials. This will signal the runner to pause.
-                    # We return None (or raise) to stop current execution.
-                    tool_context.request_credential(auth_config_adk)
-                    # Returning None here. The ADK runner will see the requested_auth_configs
-                    # in the tool_context/event and trigger the client event.
+                    # Request credentials and pause execution
+                    ctx_any.request_credential(auth_config_adk)
                     return None
             except Exception as e:
-                # If get_auth_response fails drastically or request_credential fails
                 ctx.error = e
-                # We might want to request credential if retrieval failed?
-                # For now let's assume if it fails we can't proceed.
-                # Actually, strictly we should probably request credential if get_auth_response returns nothing
-                # but get_auth_response typically handles the lookup.
-                # If exception is unrelated, raise.
-                if "credential" in str(e).lower() or isinstance(
-                    e, ValueError
-                ):  # Loose check, but safest is to re-raise
+                if "credential" in str(e).lower() or isinstance(e, ValueError):
                     raise e
-                # Fallback to request logic if it was a lookup error?
-                tool_context.request_credential(auth_config_adk)
+                # Fallback to request logic
+                ctx_any = cast(Any, tool_context)
+                ctx_any.request_credential(auth_config_adk)
                 return None
 
         try:

packages/toolbox-adk/src/toolbox_adk/toolset.py

@@ -41,7 +41,7 @@ def __init__(
         bound_params: Optional[Mapping[str, Union[Callable[[], Any], Any]]] = None,
         pre_hook: Optional[Callable[[ToolboxContext], Awaitable[None]]] = None,
         post_hook: Optional[Callable[[ToolboxContext], Awaitable[None]]] = None,
-        **kwargs,
+        **kwargs: Any,
     ):
         """
         Args:
@@ -72,13 +72,7 @@ async def get_tools(
         self, readonly_context: Optional[ReadonlyContext] = None
     ) -> List[BaseTool]:
         """Loads tools from the toolbox server and wraps them."""
-        # Note: We don't close the client after get_tools because tools might need it
-        # (though currently tools are self-contained http-wise if they don't share session state).
-        # Actually toolbox-core tools have their own client reference or use a shared one?
-        # toolbox_core.ToolboxClient.load_tool returns a tool which...
-        # wait, toolbox_core tools make HTTP calls. Do they hold a reference to the client session?
-        # Yes, toolbox_core 0.1.0+ tools usually have an internal `client` or `session`.
-        # So we must keep self._client alive or ensuring it's not closed prematurely.
+        # Note: We don't close the client after get_tools because tools might need it.
 
         tools = []
         if self._toolset_name: