chore: Improve e2e tests for optional params around null values

Author: anubhav756

packages/toolbox-core/tests/test_e2e.py

@@ -250,7 +250,7 @@ async def test_tool_signature_is_correct(self, toolbox: ToolboxClient):
         assert sig.parameters["id"].default is None
         assert sig.parameters["id"].annotation is Optional[int]
 
-    async def test_run_tool_with_optional_param_omitted(self, toolbox: ToolboxClient):
+    async def test_run_tool_with_optional_params_omitted(self, toolbox: ToolboxClient):
         """Invoke a tool providing only the required parameter."""
         tool = await toolbox.load_tool("search-rows")
 
@@ -278,6 +278,21 @@ async def test_run_tool_with_optional_data_provided(self, toolbox: ToolboxClient
         assert "row5" not in response
         assert "row6" not in response
 
+    async def test_run_tool_with_optional_data_null(self, toolbox: ToolboxClient):
+        """Invoke a tool providing both required and optional parameters."""
+        tool = await toolbox.load_tool("search-rows")
+
+        response = await tool(email="[email protected]", data=None)
+        assert isinstance(response, str)
+        assert 'email="[email protected]"' in response
+        assert "row1" not in response
+        assert "row2" in response
+        assert "row3" not in response
+        assert "row4" not in response
+        assert "row5" not in response
+        assert "row6" not in response
+
+
     async def test_run_tool_with_optional_id_provided(self, toolbox: ToolboxClient):
         """Invoke a tool providing both required and optional parameters."""
         tool = await toolbox.load_tool("search-rows")
@@ -292,8 +307,28 @@ async def test_run_tool_with_optional_id_provided(self, toolbox: ToolboxClient):
         assert "row5" not in response
         assert "row6" not in response
 
+    async def test_run_tool_with_optional_id_null(self, toolbox: ToolboxClient):
+        """Invoke a tool providing both required and optional parameters."""
+        tool = await toolbox.load_tool("search-rows")
+
+        response = await tool(email="[email protected]", id=None)
+        assert isinstance(response, str)
+        assert 'email="[email protected]"' in response
+        assert "row1" not in response
+        assert "row2" in response
+        assert "row3" not in response
+        assert "row4" not in response
+        assert "row5" not in response
+        assert "row6" not in response
+
     async def test_run_tool_with_missing_required_param(self, toolbox: ToolboxClient):
         """Invoke a tool without its required parameter."""
         tool = await toolbox.load_tool("search-rows")
         with pytest.raises(TypeError, match="missing a required argument: 'email'"):
             await tool(id=5, data="row5")
+
+    async def test_run_tool_with_required_param_null(self, toolbox: ToolboxClient):
+        """Invoke a tool without its required parameter."""
+        tool = await toolbox.load_tool("search-rows")
+        with pytest.raises(TypeError, match="missing a required argument: 'email'"):
+            await tool(email=None, id=5, data="row5")