ENH Failure to parse docker version won't crash job

Author: raydouglass

src/main/java/com/gpuopenanalytics/jenkins/remotedocker/DockerLauncher.java

@@ -365,6 +365,13 @@ private DockerVersion parseVersion() throws IOException, InterruptedException {
         }
         String versionString = baos.toString(StandardCharsets.UTF_8.name())
                 .trim();
-        return DockerVersion.fromVersionString(versionString);
+        try {
+            return DockerVersion.fromVersionString(versionString);
+        } catch (DockerVersion.VersionParseException e) {
+            getListener().getLogger().println(
+                    "WARN - Could not parse docker version");
+            e.printStackTrace(getListener().getLogger());
+            return DockerVersion.DEFAULT;
+        }
     }
 }

src/main/java/com/gpuopenanalytics/jenkins/remotedocker/DockerVersion.java

@@ -28,6 +28,9 @@
 
 public class DockerVersion implements Serializable {
 
+    public static final DockerVersion DEFAULT = new DockerVersion(0, 0, 0, null,
+                                                                  "0");
+
     private int major;
     private int minor;
     private int patch;
@@ -52,23 +55,28 @@ private DockerVersion(int major,
      *
      * @return
      */
-    public static DockerVersion fromVersionString(String versionString) {
-        String[] split = versionString.split("\\s");
-        String build = split[split.length - 1];
-        String[] version = split[2].substring(0, split[2].length() - 1).split(
-                "\\.");
-        int major = Integer.parseInt(version[0]);
-        int minor = Integer.parseInt(version[1]);
-        int patch = 0;
-        String extra = null;
-        if (version[2].contains("-")) {
-            patch = Integer.parseInt(
-                    version[2].substring(0, version[2].indexOf('-')));
-            extra = version[2].substring(version[2].indexOf('-') + 1);
-        } else {
-            patch = Integer.parseInt(version[2]);
+    public static DockerVersion fromVersionString(String versionString) throws VersionParseException {
+        try {
+            String[] split = versionString.split("\\s");
+            String build = split[split.length - 1];
+            String[] version = split[2].substring(0, split[2].length() - 1)
+                    .split(
+                            "\\.");
+            int major = Integer.parseInt(version[0]);
+            int minor = Integer.parseInt(version[1]);
+            int patch = 0;
+            String extra = null;
+            if (version[2].contains("-")) {
+                patch = Integer.parseInt(
+                        version[2].substring(0, version[2].indexOf('-')));
+                extra = version[2].substring(version[2].indexOf('-') + 1);
+            } else {
+                patch = Integer.parseInt(version[2]);
+            }
+            return new DockerVersion(major, minor, patch, extra, build);
+        } catch (Exception e) {
+            throw new VersionParseException(versionString, e);
         }
-        return new DockerVersion(major, minor, patch, extra, build);
     }
 
     public String getVersionString() {
@@ -91,4 +99,11 @@ public String toString() {
                                  build);
         }
     }
+
+    public static class VersionParseException extends Exception {
+
+        public VersionParseException(String version, Throwable cause) {
+            super(String.format("Could not parse '%s'", version), cause);
+        }
+    }
 }