fSampleRate is not initialized in SubContainers

[crop2000]

import("stdfaust.lib");
process = rdtable(100,ma.SR,ba.time%100);

produces:

class mydspSIG0 {
	
  private:
	
	int fSampleRate;
	float fConst0;
	
  public:
	
	int getNumInputsmydspSIG0() {
		return 0;
	}
	int getNumOutputsmydspSIG0() {
		return 1;
	}
	
	void instanceInitmydspSIG0(int sample_rate) {
		fConst0 = std::min<float>(1.92e+05f, std::max<float>(1.0f, float(fSampleRate)));
	}
	
	void fillmydspSIG0(int count, float* table) {
		for (int i1 = 0; i1 < count; i1 = i1 + 1) {
			table[i1] = fConst0;
		}
	}

};

static mydspSIG0* newmydspSIG0() { return (mydspSIG0*)new mydspSIG0(); }
static void deletemydspSIG0(mydspSIG0* dsp) { delete dsp; }

static float ftbl0mydspSIG0[100];

the subcontainer does not initialize the sample rate.

I would suggest to restrict the use of fSampleRate in tables. So that this problem doesn't stays unnoticed.

[sletz]

Why ? The missing initialisation should be better fixed.

[crop2000]

Because it would reflect what is currently possible and would allow simplification of the interface. I agree that my position is debatable and I will not further argue for it.

[crop2000]

I would still argue for a flag that disables the use of sample rate in subcontainers that can be automatically disabled when back-ends implement the solution:

in every backend this section has to added to the subcontainer generator:

faust/compiler/generator/cpp/cpp_code_container.cpp

Lines 556 to 607 in 586dc77

	tab(n + 1, *fOut);
	tab(n + 1, *fOut);
	*fOut << genVirtual() << "void instanceConstants(int sample_rate) {";
	tab(n + 2, *fOut);
	fCodeProducer->Tab(n + 2);
	if (gGlobal->gInlineTable) {
	// 'delete' instruction which are in fPostInitInstructions are not generated
	fInitInstructions->accept(fCodeProducer);
	} else {
	generateInit(fCodeProducer);
	}
	back(1, *fOut);
	*fOut << "}";
	tab(n + 1, *fOut);
	if (gGlobal->gMemoryManager == 2) {
	tab(n + 1, *fOut);
	*fOut << genVirtual() << "void instanceConstantsFromMem(int sample_rate) {";
	tab(n + 2, *fOut);
	faustassert(fConstantFromMem);
	fConstantFromMem->accept(fCodeProducer);
	back(1, *fOut);
	*fOut << "}";
	tab(n + 1, *fOut);
	tab(n + 1, *fOut);
	*fOut << genVirtual() << "void instanceConstantsToMem(int sample_rate) {";
	tab(n + 2, *fOut);
	faustassert(fConstantToMem);
	fConstantToMem->accept(fCodeProducer);
	back(1, *fOut);
	*fOut << "}";
	tab(n + 1, *fOut);
	}
	tab(n + 1, *fOut);
	*fOut << genVirtual() << "void instanceResetUserInterface() {";
	tab(n + 2, *fOut);
	fCodeProducer->Tab(n + 2);
	generateResetUserInterface(fCodeProducer);
	back(1, *fOut);
	*fOut << "}";
	tab(n + 1, *fOut);
	tab(n + 1, *fOut);
	*fOut << genVirtual() << "void instanceClear() {";
	tab(n + 2, *fOut);
	fCodeProducer->Tab(n + 2);
	generateClear(fCodeProducer);
	back(1, *fOut);
	*fOut << "}";
	tab(n + 1, *fOut);

[sletz]

So, no for "a flag that disables the use of sample rate in subcontainers"

[crop2000]

but who will implement this for all backends ... why not throw an error when a backend hasn't been updated?