-
Notifications
You must be signed in to change notification settings - Fork 122
feat(sdk-rs): circuit breaker and multiple endpoints #7380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: builder-pattern
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the robustness and availability of the Hive Console Rust SDK and its Apollo Router Plugin by integrating a circuit breaker pattern and enabling the use of multiple CDN endpoints. These changes allow the system to gracefully handle failures and switch to healthy endpoints, ensuring continuous operation even when some services are degraded. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
hive |
8.13.0-alpha-20251206000002-402da7cdce2495c4de09443c4fcfee14a17e82a4 |
npm ↗︎ unpkg ↗︎ |
hive-apollo-router-plugin |
3.0.0-alpha-20251206000002-402da7cdce2495c4de09443c4fcfee14a17e82a4 |
npm ↗︎ unpkg ↗︎ |
hive-console-sdk-rs |
0.3.0-alpha-20251206000002-402da7cdce2495c4de09443c4fcfee14a17e82a4 |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7380.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces circuit breaker functionality and support for multiple endpoints to the Rust SDK and Apollo Router plugin, enhancing resilience. The changes involve breaking API updates for configuration. My review identifies critical issues with potential panics in the supergraph_fetcher due to improper error handling, and medium-severity issues in circuit_breaker.rs related to code duplication and a misleading comment.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7380.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Ref CONSOLE-1605
Rust SDK
Circuit Breaker Implementation and Multiple Endpoints Support
Implementation of Circuit Breakers in Hive Console Rust SDK, you can learn more here
Breaking Changes:
Now
endpointconfiguration accepts multiple endpoints as an array forSupergraphFetcherBuilderandPersistedDocumentsManager.This change requires updating the configuration structure to accommodate multiple endpoints.
Apollo Router Plugin
HiveRegistryandPersistedOperationsPluginBreaking Changes:
endpointfield in the configuration, it has been replaced withendpoints, which is an array of strings. You are not affected if you use environment variables to set the endpoint.HiveRegistry::new( Some( HiveRegistryConfig { - endpoint: String::from("CDN_ENDPOINT"), + endpoints: vec![String::from("CDN_ENDPOINT1"), String::from("CDN_ENDPOINT2")], ) )