[Bug]: Error 500/TypeError in Units.php for Warranty Months

[sylvank]

Snipe-IT Version

v8.3.3 - build 20061

PHP Version

8.4.12

Composer Version

2.8.11

MySQL/MariaDB version

10.11.14

How did you install Snipe-IT?

Git install

Is this a fresh install or an upgrade?

Upgrade

What happened?

Hello, I'm having a similar issue to one I had a few months ago: error 500 in /api/v1/hardware and "TypeError: Carbon\Carbon::rawAddUnit(): Argument #3 ($value) must be of type int|float, string given" from Laravel.

Previous issue: #16925

I believe I've narrowed down the problem:

If "Warranty" is blank or 0 Months, the item will display in a list. However, if I enter any other number, the list will not display.

This started when upgrading to Snipe-It 8.3.3 20061 this morning. It had been a couple months since I last upgraded. (I will try to remember to backup the Snipe-It install first next time).
- I've run the recommended commands from Common Issues
- Ran php.upgrade again
- Tried in another browser & user account
- Upgraded from PHP 8.3 to 8.4

Based on the error, I added in Units.php:
/**
* Add given units to the current instance.
*/
public function addUnit(Unit|string $unit, $value = 1, ?bool $overflow = null): static
{
$unit = Unit::toName($unit);
$value = (int) $value;

And now the item displays in lists correctly with Warranty Months=1

I've confirmed in PHPMyAdmin that the "warranty_months" field is int(11).
Items that don't display/stop the asset list from displaying can be viewed normally via their asset tag number. The warranty expiry date displays correctly in the asset view when Warranty Months has a value.

This is an example export from Custom Asset Report when Warranty Months = 1

ID,Company,"Asset Name","Asset Tag",Model,"Model No.",Category,Manufacturer,Serial,Purchased,Cost,EOL,Warranty,"Warranty Expires","Current Value",Diff,"Fully Depreciated","Order Number",Supplier,Location,Address,Address,City,State,Country,Zip,"Default Location",Address,Address,City,State,Country,Zip,"Checked Out",Type,Username,"Employee No.",Manager,Department,Title,Phone,"User Address","User City","User State","User Country","User Zip",Status,"Checkout Date","Last Checkin Date","Expected Checkin Date","Created At","Updated at",Deleted,"Last Audit","Next Audit Date",Notes,URL,"MAC Address",Specs,"Applecare Policy",CpyWarrantyExpiry,"OS Version",Power,"Cable #",Condition,"Model Year",Accessories,Contents,SIM/Carrier,"Phone Number","Lock Code",IMEI
644,,"UGreen USB-C to USB-C 1.5m",1644,"UGreen USB-C to USB-C 1.5m",US161,Cables-Numbered,UGreen,,"2025-03-06 00:00:00",14.99,,1,2025-04-06,14.99,0.00,,,"Memory Express",,,,,,,,,,,,,,,,,,,,,,,,,,,,"Ready to Deploy (deployable)",,,,"2025-03-17 22:19:09","2025-10-06 15:25:50",,,,,https://DOMAIN/hardware/644,,,,,,,,,,,,,,,

And the SQL:
INSERT INTO assets (id, name, asset_tag, model_id, serial, purchase_date, asset_eol_date, eol_explicit, purchase_cost, order_number, assigned_to, notes, image, created_by, created_at, updated_at, physical, deleted_at, status_id, archived, warranty_months, depreciate, supplier_id, requestable, rtd_location_id, _snipeit_mac_address_1, accepted, last_checkout, last_checkin, expected_checkin, company_id, assigned_type, last_audit_date, next_audit_date, location_id, checkin_counter, checkout_counter, requests_counter, byod, _snipeit_specs_2, _snipeit_applecare_policy_3, _snipeit_cpywarrantyexpiry_4, _snipeit_os_version_5, _snipeit_power_6, _snipeit_cable_7, _snipeit_condition_8, _snipeit_model_year_9, _snipeit_accessories_10, _snipeit_contents_11, _snipeit_sim_carrier_12, _snipeit_phone_number_13, _snipeit_lock_code_14, _snipeit_imei_15) VALUES
(644, 'UGreen USB-C to USB-C 1.5m', '1644', 126, NULL, '2025-03-06', NULL, 0, 14.99, NULL, NULL, NULL, NULL, 1, '2025-03-18 02:19:09', '2025-10-06 19:48:20', 1, NULL, 2, 0, 1, NULL, 7, 0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);

What browsers are you seeing the problem on?

Chrome

Can you reproduce this on the public demo?

No

Do you have full multiple company support enabled?

No

If you have full multiple company support enabled, do you have location scoping to company enabled?

I do not have full multiple company support enabled

Application log output

[11:23:49] LOG.error: TypeError: Carbon\Carbon::rawAddUnit(): Argument #3 ($value) must be of type int|float, string given, called in /home/USER/domains/DOMAIN/snipe-it/vendor/nesbot/carbon/src/Carbon/Traits/Units.php on line 356 and defined in /home/USER/domains/DOMAIN/snipe-it/vendor/nesbot/carbon/src/Carbon/Traits/Units.php:455
Stack trace:
#0 /home/USER/domains/DOMAIN/snipe-it/vendor/nesbot/carbon/src/Carbon/Traits/Units.php(356): Carbon\Carbon::rawAddUnit()
#1 /home/USER/domains/DOMAIN/snipe-it/vendor/nesbot/carbon/src/Carbon/Traits/Date.php(2905): Carbon\Carbon->addUnit()
#2 /home/USER/domains/DOMAIN/snipe-it/vendor/nesbot/carbon/src/Carbon/Traits/Date.php(2596): Carbon\Carbon->callModifierMethod()
#3 /home/USER/domains/DOMAIN/snipe-it/app/Models/Asset.php(283): Carbon\Carbon->__call()
#4 [internal function]: App\Models\Asset->App\Models\{closure}()
#5 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(718): call_user_func()
#6 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(2226): Illuminate\Database\Eloquent\Model->mutateAttributeMarkedAttribute()
#7 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(520): Illuminate\Database\Eloquent\Model->transformModelValue()
#8 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(474): Illuminate\Database\Eloquent\Model->getAttributeValue()
#9 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(2260): Illuminate\Database\Eloquent\Model->getAttribute()
#10 /home/USER/domains/DOMAIN/snipe-it/app/Http/Transformers/AssetsTransformer.php(91): Illuminate\Database\Eloquent\Model->__get()
#11 /home/USER/domains/DOMAIN/snipe-it/app/Http/Transformers/AssetsTransformer.php(21): App\Http\Transformers\AssetsTransformer->transformAsset()
#12 /home/USER/domains/DOMAIN/snipe-it/app/Http/Controllers/Api/AssetsController.php(456): App\Http\Transformers\AssetsTransformer->transformAssets()
#13 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): App\Http\Controllers\Api\AssetsController->index()
#14 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(44): Illuminate\Routing\Controller->callAction()
#15 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Route.php(266): Illuminate\Routing\ControllerDispatcher->dispatch()
#16 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Route.php(212): Illuminate\Routing\Route->runController()
#17 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Router.php(808): Illuminate\Routing\Route->run()
#18 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(170): Illuminate\Routing\Router->Illuminate\Routing\{closure}()
#19 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(51): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#20 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Routing\Middleware\SubstituteBindings->handle()
#21 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/SetAPIResponseHeaders.php(68): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#22 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Middleware/ThrottleRequests.php(127): App\Http\Middleware\SetAPIResponseHeaders->handleRequest()
#23 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Middleware/ThrottleRequests.php(89): Illuminate\Routing\Middleware\ThrottleRequests->handleRequestUsingNamedLimiter()
#24 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Routing\Middleware\ThrottleRequests->handle()
#25 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/CheckLocale.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#26 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\CheckLocale->handle()
#27 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php(64): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#28 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Auth\Middleware\Authenticate->handle()
#29 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(127): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#30 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Router.php(807): Illuminate\Pipeline\Pipeline->then()
#31 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Router.php(786): Illuminate\Routing\Router->runRouteWithinStack()
#32 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Router.php(750): Illuminate\Routing\Router->runRoute()
#33 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Router.php(739): Illuminate\Routing\Router->dispatchToRoute()
#34 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(201): Illuminate\Routing\Router->dispatch()
#35 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(170): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}()
#36 /home/USER/domains/DOMAIN/snipe-it/vendor/livewire/livewire/src/Features/SupportDisablingBackButtonCache/DisableBackButtonCacheMiddleware.php(19): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#37 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Livewire\Features\SupportDisablingBackButtonCache\DisableBackButtonCacheMiddleware->handle()
#38 /home/USER/domains/DOMAIN/snipe-it/vendor/barryvdh/laravel-debugbar/src/Middleware/InjectDebugbar.php(66): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#39 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Barryvdh\Debugbar\Middleware\InjectDebugbar->handle()
#40 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php(62): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#41 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Http\Middleware\HandleCors->handle()
#42 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/PreventBackHistory.php(23): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#43 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\PreventBackHistory->handle()
#44 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/SecurityHeaders.php(26): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#45 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\SecurityHeaders->handle()
#46 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#47 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(51): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()
#48 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Foundation\Http\Middleware\TrimStrings->handle()
#49 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#50 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()
#51 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle()
#52 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/CheckForDebug.php(25): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#53 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\CheckForDebug->handle()
#54 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/CheckForSetup.php(30): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#55 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\CheckForSetup->handle()
#56 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#57 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\View\Middleware\ShareErrorsFromSession->handle()
#58 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(121): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#59 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Session\Middleware\StartSession->handleStatefulRequest()
#60 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Session\Middleware\StartSession->handle()
#61 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(110): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#62 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle()
#63 /home/USER/domains/DOMAIN/snipe-it/app/Http/Middleware/NoSessionStore.php(28): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#64 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): App\Http\Middleware\NoSessionStore->handle()
#65 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(58): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#66 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Http\Middleware\TrustProxies->handle()
#67 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(127): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#68 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\Pipeline\Pipeline->then()
#69 /home/USER/domains/DOMAIN/snipe-it/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(145): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter()
#70 /home/USER/domains/DOMAIN/snipe-it/public/index.php(51): Illuminate\Foundation\Http\Kernel->handle()
#71 {main}

Browser console output

status
500 Internal Server Error
full_url
https://DOMAIN/api/v1/hardware?status=&order_number=&company_id=&status_id=&search=&sort=status_label&order=asc&offset=0&limit=500
action_name
api.assets.index
controller_action
App\Http\Controllers\Api\AssetsController@index
uri
GET api/v1/hardware
controller
App\Http\Controllers\Api\AssetsController@index
prefix
api/v1
file
app/Http/Controllers/Api/AssetsController.php:59-457
middleware
auth:api, api, api-throttle:api
duration
314ms
peak_memory
14MB
response
application/json
request_format
html
request_query
array:9 [▼
  "status" => null
  "order_number" => null
  "company_id" => null
  "status_id" => null
  "search" => null
  "sort" => "status_label"
  "order" => "asc"
  "offset" => "0"
  "limit" => "500"
]
request_request
[]
request_headers
array:17 [▼
  "accept" => array:1 [▶]
  "accept-encoding" => array:1 [▶]
  "accept-language" => array:1 [▶]
  "content-type" => array:1 [▶]
  "cookie" => array:1 [▶]
  "host" => array:1 [▶]
  "referer" => array:1 [▶]
  "user-agent" => array:1 [▶]
  "sec-ch-ua-platform" => array:1 [▶]
  "x-csrf-token" => array:1 [▶]
  "sec-ch-ua" => array:1 [▶]
  "sec-ch-ua-mobile" => array:1 [▶]
  "x-requested-with" => array:1 [▶]
  "sec-fetch-site" => array:1 [▶]
  "sec-fetch-mode" => array:1 [▶]
  "sec-fetch-dest" => array:1 [▶]
  "priority" => array:1 [▶]
]

Common Issues

• I have searched this repo for existing issues related to my issue (including closed issues)
• My APP_URL is set correctly in my .env file (including http or https and no trailing slash)
• I have searched the official Snipe-IT documentation and have checked the Common Issues documentation (where applicable)
• I have run database migrations (where applicable).
• I have attached screenshots and/or videos of the issue (where applicable)

Code of Conduct

• I agree to follow this project's Code of Conduct

[snipe]

You should never be changing vendor files, since the next time you upgrade, those changes will be blown out.

I have no idea why you'd be seeing that, as that is never treated as a string and I cannot reproduce it locally or on the demo.

https://demo.snipeitapp.com/hardware

Snipe-IT Asset Management Demo

[sylvank]

@snipe I understand about the vendor files; I was just trying to pin down the problem.

I've done a completely fresh install of snipe-it and dependencies, with no change.
I've done a backup & re-imported the database, with no change.

I've made this change in Asset.php and it fixes the problem:

protected function warrantyExpires(): Attribute
{
return Attribute:: make(
get: fn(mixed $value, array $attributes) => ($attributes['warranty_months'] && $attributes['purchase_date']) ? Carbon::parse($attributes['purchase_date'])->addMonths((int) $attributes['warranty_months']) : null,
);
}

(Added (int) in the addMonths() call)

This fixes the current problem.

Again, this is very similar to the previous issue at #16925

As said warranty_months in the database is an int field; but it looks like somehow $attributes['warranty_months'] is being passed as a string to the addUnit() function?

[sylvank]

@snipe I've just updated to version 8.3.4 - 20218.

Same problem as before, and forcing warranty_months to int fixes again:

Carbon::parse($attributes['purchase_date'])->addMonths((int)$attributes['warranty_months']) : null,

I believe there's something wrong in my database somewhere, but as said everything in warranty_months appears to be an int or null.

I'm carefully looking at the values in warranty_months; if I set 1 to null from phymyadmin the item will display.

Again, this appears to be the same issue as in #16925 but with a different field. Would it make sense to simply force the field to int() as I've done above? Otherwise I'd be glad to do what I can to debug this further.

[edwardcallow]

Hey @sylvank thanks for your work on this. I’ve had exactly the same issue after upgrading (to v8.3.4) for the first time in a few months. Found that similar #16925 issue but didn’t quite apply to me and ,like you, everything in warranty_months seems good.
Forcing it to int as you’ve done above at least works for now.

[snipe]

Fixed in 92b50ca