Move DOA error handling inside setOutgoingBinder().

Where it can be shared by both upcoming client handshake impls.

Author: jdcormie

binder/src/main/java/io/grpc/binder/internal/BinderClientTransport.java

@@ -336,8 +336,6 @@ protected void handleSetupTransport(Parcel parcel) {
     }
 
     if (!setOutgoingBinder(OneWayBinderProxy.wrap(binder, offloadExecutor))) {
-      shutdownInternal(
-          Status.UNAVAILABLE.withDescription("Failed to observe outgoing binder"), true);
       return;
     }
 

binder/src/main/java/io/grpc/binder/internal/BinderServerTransport.java

@@ -66,8 +66,7 @@ public static BinderServerTransport create(
         new BinderServerTransport(
             executorServicePool, attributes, streamTracerFactories, binderDecorator);
     // TODO(jdcormie): Plumb in the Server's executor() and use it here instead.
-    // No need to handle failure here because if 'callbackBinder' is already dead, we'll notice it
-    // again in start() when we send the first transaction.
+    // Ignore failure here -- start() can handle the already shutdown state.
     transport.setOutgoingBinder(
         OneWayBinderProxy.wrap(callbackBinder, transport.getScheduledExecutorService()));
     return transport;
@@ -84,8 +83,8 @@ public static BinderServerTransport create(
   public synchronized void start(ServerTransportListener serverTransportListener) {
     this.listenerPromise.set(serverTransportListener);
     if (isShutdown()) {
-      // It's unlikely, but we could be shutdown externally between construction and start(). One
-      // possible cause is an extremely short handshake timeout.
+      // It's unlikely, but we could be shutdown externally between construction and start().
+      // Cause could be an extremely short handshake timeout or a dead-on-arrival client binder.
       return;
     }
 

binder/src/main/java/io/grpc/binder/internal/BinderTransport.java

@@ -283,8 +283,8 @@ final void setState(TransportState newState) {
    *
    * <p>Subclasses should call this as early as possible but not from a constructor.
    *
-   * <p>Returns true for success, false if the process hosting 'binder' is already dead. Callers are
-   * responsible for handling this.
+   * <p>Returns true for success. Returns true if the process hosting 'binder' is already dead. In
+   * the latter case, this instance will have been shutdown with an appropriate error status.
    */
   @GuardedBy("this")
   protected boolean setOutgoingBinder(OneWayBinderProxy binder) {
@@ -294,6 +294,9 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) {
       binder.getDelegate().linkToDeath(this, 0);
       return true;
     } catch (RemoteException re) {
+      shutdownInternal(
+          Status.UNAVAILABLE.withDescription("Failed to observe outgoing binder").withCause(re),
+          true);
       return false;
     }
   }