-
Notifications
You must be signed in to change notification settings - Fork 35
doc: minor release process #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideAdds a new “Releasing the minor version” section to RELEASE.md with step-by-step commands for preparing and publishing a minor release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `RELEASE.md:177` </location>
<code_context>
+When releasing the minor version, there's a subset of steps that needs to be done.
+Here's the example releasing version `0.4.4` from `release/0.4.z` branch with all the commits for the release cherry-picked into it:
+
+* Make sure you are starting with updated release branch
+
+```shell
</code_context>
<issue_to_address>
**suggestion (typo):** Add 'an' before 'updated release branch' for grammatical correctness.
It should be 'an updated release branch.'
```suggestion
* Make sure you are starting with an updated release branch
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Dejan Bosanac <[email protected]>
9107d40 to
49cd08f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
=======================================
Coverage 68.14% 68.15%
=======================================
Files 371 371
Lines 20838 20838
Branches 20838 20838
=======================================
+ Hits 14200 14202 +2
+ Misses 5799 5794 -5
- Partials 839 842 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it looks like this duplicates the content from the beginning of the document. I am all for making it more compact/concise. But I don't think that duplicating content in the same file is a good idea.
Summary by Sourcery
Documentation: