Respect Global State When Running Tests #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a lot of things that were eagerly running before tests. These should be wrapped in Moacha's `beforeEach` hook. This prevents an issue such as the following: ``` Uncaught TypeError: undefined is not a function tests.js:5 ``` In truth, there's a deeper loading issue to resolve. This problem would have cropped up sooner or later anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of things that were eagerly running before tests. These
should be wrapped in Moacha's
beforeEachhook. This prevents an issuesuch as the following:
In truth, there's a deeper loading issue to resolve. This problem would
have cropped up sooner or later anyways.