Skip to content
This repository was archived by the owner on Nov 23, 2018. It is now read-only.
This repository was archived by the owner on Nov 23, 2018. It is now read-only.

CSS filename replacement in HTML is placing quotes in incorrect places when HTML is actually a server side template #153

@kierans

Description

@kierans

For my project the CSS is concatenated/minified by h5bp however the HTML pages are actually JSP tag templates. The current replacement regexp is assuming where the quotes should go and this is causing problems when using JSP snippets eg:

<link rel="stylesheet" href="<%= application.getContextPath() + "/css/main.css" %>">

produces

<link rel="stylesheet" href='<%= application.getContextPath() + "/css/3f2f17c.css' %>">

which causes JSP errors, as the single quotes are added by the Ant regexp replace.

The regexp IMO should actually capture everything (including quotes) around the filename ie: main.css and just replace the filename.

I'll be submitting a pull request with a fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions