Move SSL alerts to BWebWindow

This allows client to overwrite the alert with another handling for SSL
errors.
DumpRenderTree replaces it by an "always accept" strategy, which allows
to run the test suite without constantly clicking the "continue" button
for hundreds of requests using a self signed certificate.

Author: pulkomandy

Source/WebKit/haiku/API/WebViewConstants.h

@@ -50,7 +50,8 @@ enum {
     MAIN_DOCUMENT_ERROR =                               318,
     LOAD_STARTED =                                      319,
     RESPONSE_RECEIVED =                                 320,
-    ICON_CHANGED =                                      321
+    ICON_CHANGED =                                      321,
+    SSL_CERT_ERROR =                                    322
 };
 
 enum {

Source/WebKit/haiku/API/WebWindow.cpp

@@ -246,30 +246,48 @@ void BWebWindow::MessageReceived(BMessage* message)
         break;
     }
     case AUTHENTICATION_CHALLENGE: {
-	    BString text;
-	    bool rememberCredentials = false;
-	    uint32 failureCount = 0;
-	    BString user;
-	    BString password;
+        BString text;
+        bool rememberCredentials = false;
+        uint32 failureCount = 0;
+        BString user;
+        BString password;
 
-	    message->FindString("text", &text);
-	    message->FindString("user", &user);
-	    message->FindString("password", &password);
-	    message->FindUInt32("failureCount", &failureCount);
+        message->FindString("text", &text);
+        message->FindString("user", &user);
+        message->FindString("password", &password);
+        message->FindUInt32("failureCount", &failureCount);
 
         if (!AuthenticationChallenge(text, user, password, rememberCredentials,
-        		failureCount, _WebViewForMessage(message))) {
-        	message->SendReply((uint32)0);
-        	break;
+                failureCount, _WebViewForMessage(message))) {
+            message->SendReply((uint32)0);
+            break;
         }
 
-	    BMessage reply;
-	    reply.AddString("user", user);
-	    reply.AddString("password", password);
-	    reply.AddBool("rememberCredentials", rememberCredentials);
-	    message->SendReply(&reply);
+        BMessage reply;
+        reply.AddString("user", user);
+        reply.AddString("password", password);
+        reply.AddBool("rememberCredentials", rememberCredentials);
+        message->SendReply(&reply);
         break;
     }
+    case SSL_CERT_ERROR: {
+        BString text;
+
+        message->FindString("text", &text);
+
+        BAlert* alert = new BAlert("Unsecure SSL certificate", text,
+            "Continue", "Stop", NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT);
+        // TODO add information about the certificate to the alert
+        // (in a "details" area or so)
+        // (but this can be done in WebPositive as well)
+
+        int button = alert->Go();
+        BMessage reply;
+        reply.AddBool("continue", button == 0);
+        message->SendReply(&reply);
+        break;
+    }
+
 
     case TOOLBARS_VISIBILITY: {
         bool flag;

Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp

@@ -238,22 +238,27 @@ void FrameLoaderClientHaiku::dispatchDidCancelAuthenticationChallenge(DocumentLo
 
 
 bool FrameLoaderClientHaiku::dispatchDidReceiveInvalidCertificate(DocumentLoader*,
-    const CertificateInfo& /*certificate*/, const char* message)
+    const CertificateInfo& certificate, const char* message)
 {
+	// FIXME use m_messenger as above, so that the alert is generated from the
+	// API side and can be overriden by clients with a fancier one (or hidden
+	// completely in case of DumpRenderTree).
     String text = "The SSL certificate received from " + 
         m_webFrame->Frame()->document()->url().string() + " could not be "
         "authenticated for the following reason: " + message + ".\n\n"
         "The secure connection to the website may be compromised, make sure "
         "to not send any sensitive information.";
 
-    // TODO add information about the certificate to the alert (in a "details" area or so)
+    BMessage warningMessage(SSL_CERT_ERROR);
+    warningMessage.AddString("text", text.utf8().data());
+    warningMessage.AddPointer("certificate info", &certificate);
 
-    BAlert* alert = new BAlert("Unsecure SSL certificate", text.utf8().data(),
-        "Continue", "Stop", NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT);
+    BMessage reply;
+    m_messenger.SendMessage(&warningMessage, &reply);
 
-    int button = alert->Go();
+    bool continueAnyway = reply.FindBool("continue");
 
-    return button == 0;
+    return continueAnyway;
 }
 
 

Tools/DumpRenderTree/haiku/DumpRenderTree.cpp

@@ -488,6 +488,21 @@ class DumpRenderTreeChrome: public BWebWindow
             B_NO_BORDER_WINDOW_LOOK, B_NORMAL_WINDOW_FEEL, 0)
     {
     }
+
+    void MessageReceived(BMessage* msg)
+    {
+        if (msg->what == SSL_CERT_ERROR)
+        {
+            // Always accept SSL certificates, since the test suite uses an
+            // auto-generated one and that would normally produce warnings.
+            BMessage reply;
+            reply.AddBool("continue", true);
+            msg->SendReply(&reply);
+            return;
+        }
+
+        BWebWindow::MessageReceived(msg);
+    }
 };
 
 void DumpRenderTreeApp::ReadyToRun()