Skip to content

Commit ab100a8

Browse files
committed
MINOR: README: add warning about comma in value string
When using helm cli with `--set` parameters, one also need to escape commas ',' in the value string, such as: helm upgrade syslog haproxytech/kubernetes-ingress \ --set controller.config."syslog-server"="address:127.0.0.1\, facility:local0\, format:raw\, level:notice" otherwise such error is returned: Error: failed parsing --set data: key " format:raw, level:notice" has no value
1 parent aa15693 commit ab100a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kubernetes-ingress/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ helm install my-ingress3 haproxytech/kubernetes-ingress \
111111
--set controller.service.annotations."service\.beta\.kubernetes\.io/aws-load-balancer-cross-zone-load-balancing-enabled"="true"
112112
```
113113

114-
***NOTE***: With helm `--set` it is needed to put quotes and escape dots in the annotation key.
114+
***NOTE***: With helm `--set` it is needed to put quotes and escape dots in the annotation key and commas in the value string.
115115

116116
### Using values from YAML file
117117

@@ -164,4 +164,4 @@ helm install my-release haproxytech/kubernetes-ingress \
164164

165165
## Contributing
166166

167-
We welcome all contributions. Please refer to [guidelines](../CONTRIBUTING.md) on how to make a contribution.
167+
We welcome all contributions. Please refer to [guidelines](../CONTRIBUTING.md) on how to make a contribution.

0 commit comments

Comments
 (0)