Merge pull request #264 from hashicorp/dependabot/github_actions/actions-b5bd5a21f8

[chore] : Bump golangci/golangci-lint-action from 6.5.2 to 8.0.0 in the actions group

Author: jackofallops

.github/workflows/pr-unit-tests.yaml

@@ -19,7 +19,7 @@ jobs:
           go-version: ${{matrix.go-version}}
 
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9
 
       - name: Run unit tests and generate coverage report
         run: make test

.golangci.yml

@@ -1,10 +1,25 @@
-# Copyright (c) HashiCorp, Inc.
-# SPDX-License-Identifier: MPL-2.0
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - errcheck
-    - staticcheck
-    - gosimple
     - govet
+    - staticcheck
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

client_test.go

@@ -468,7 +468,7 @@ func TestClient_Do_WithPrepareRetry(t *testing.T) {
 			if prepareChecks != tt.expectedPrepareChecks {
 				t.Fatalf("expected %d attempts of prepare check, got %d attempts", tt.expectedPrepareChecks, prepareChecks)
 			}
-			header := req.Request.Header.Get("foo")
+			header := req.Header.Get("foo")
 			if tt.expectedPrepareChecks == 0 && header != "" {
 				t.Fatalf("expected no changes to request header 'foo', but got '%s'", header)
 			}
@@ -746,7 +746,7 @@ func TestClient_RequestWithContext(t *testing.T) {
 	if err != nil {
 		t.Fatalf("err: %v", err)
 	}
-	ctx, cancel := context.WithCancel(req.Request.Context())
+	ctx, cancel := context.WithCancel(req.Context())
 	reqCtx := req.WithContext(ctx)
 	if reqCtx == req {
 		t.Fatal("WithContext must return a new Request object")
@@ -757,7 +757,7 @@ func TestClient_RequestWithContext(t *testing.T) {
 	called := 0
 	client.CheckRetry = func(_ context.Context, resp *http.Response, err error) (bool, error) {
 		called++
-		return DefaultRetryPolicy(reqCtx.Request.Context(), resp, err)
+		return DefaultRetryPolicy(reqCtx.Context(), resp, err)
 	}
 
 	cancel()