Skip to content

Commit e3867e3

Browse files
committed
resolved comments
1 parent a75949c commit e3867e3

File tree

5 files changed

+9
-40
lines changed

5 files changed

+9
-40
lines changed

.github/workflows/pr-unit-tests-1.22.yaml

Lines changed: 0 additions & 34 deletions
This file was deleted.
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
1-
name: Unit tests (Go 1.19)
1+
name: Unit tests
22
on:
33
pull_request:
44
types: ['opened', 'synchronize']
55

66
jobs:
77
run-tests:
88
runs-on: ubuntu-latest
9+
strategy:
10+
matrix:
11+
go-version: ['1.23', '1.22', '1.19']
912
steps:
1013
- name: Checkout Code
1114
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
1215

1316
- name: Setup Go
1417
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
1518
with:
16-
go-version: 1.19
19+
go-version: ${{matrix.go-version}}
1720

1821
- name: Run golangci-lint
1922
uses: golangci/golangci-lint-action@08e2f20817b15149a52b5b3ebe7de50aff2ba8c5
@@ -25,7 +28,7 @@ jobs:
2528
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
2629
with:
2730
path: coverage.out
28-
name: Coverage-report-1.19
31+
name: Coverage-report-${{matrix.go-version}}
2932

3033
- name: Display coverage test
3134
run: go tool cover -func=coverage.out

.go-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.22.2
1+
1.23

client_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ func testClientDo(t *testing.T, body interface{}) {
223223
t.Fatalf("err: %v", err)
224224
}
225225
defer list.Close()
226-
errors := make(chan error)
226+
errors := make(chan error, 1)
227227
go func() {
228228
err := http.Serve(list, handler)
229229
if err != nil {

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ require (
1212
golang.org/x/sys v0.20.0 // indirect
1313
)
1414

15-
go 1.19
15+
go 1.23

0 commit comments

Comments
 (0)