Skip to content

Commit bd23f41

Browse files
committed
Merge branch 'asyncio-module-ssl' into asyncio-module-integration-tests1
2 parents e673679 + d9acede commit bd23f41

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

hazelcast/internal/asyncio_connection.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ async def on_connection_close(self, closed_connection):
342342

343343
if removed:
344344
async with asyncio.TaskGroup() as tg:
345-
# TODO: see on_connection_open
346345
for _, on_connection_closed in self._connection_listeners:
347346
if on_connection_closed:
348347
try:
@@ -474,7 +473,6 @@ async def run():
474473
connecting_uuids.add(member_uuid)
475474
if not self._lifecycle_service.running:
476475
break
477-
# TODO: ERROR:asyncio:Task was destroyed but it is pending!
478476
tg.create_task(self._get_or_connect_to_member(member))
479477
member_uuids.append(member_uuid)
480478

@@ -707,8 +705,6 @@ async def _handle_successful_auth(self, response, connection):
707705
for on_connection_opened, _ in self._connection_listeners:
708706
if on_connection_opened:
709707
try:
710-
# TODO: creating the task may not throw the exception
711-
# TODO: protect the loop against exceptions, so all handlers run
712708
maybe_coro = on_connection_opened(connection)
713709
if isinstance(maybe_coro, Coroutine):
714710
tg.create_task(maybe_coro)

0 commit comments

Comments
 (0)