Include context inside uc.authorize()

[thgpdr]

Hey guys, I came across a problem theses days, which was:
I needed to test a use case that had an external client call inside authorize(), like calling another micro service to check some user permissions before authorizing the use case execution.

I did realize that I could not inject the external client while testing, because .authorize() do not receive the use case context as a parameter, so I needed to mock the hole external client require or override the ._authorize()

const ucMyBusinessRule = MyBusinessRule()
ucMyBusinessRule._authorize = async () => {
  return { isOk: true }
}

await ucMyBusinessRule.authorize()
const ret = await ucMyBusinessRule.run(parameters)

if (ret.isErr) console.log(ret.err)

const { ruleRet } = ret.ok

expect(ruleRet.isValid()).to.be.true

I dont know if its an real issue and we should add ctx inside the authorize() or that is the expected behavior, since its a convention to not use context inside authorize step. What your thoughts on this?

[PedroHaupenthal]

@thgpdr Complement in your comment, I went through a very similar situation, that my authorize() called an injected external client but in the unit test the ctx always returned empty.

I found this to be because setup generates the context only after usecase.run().
But authorize() is done before run().

Take a look at how usecases are written in the new herbs-cli . You will see that setup is not used and I believe that this can solve the problem.

[dalssoft]

@PedroHaupenthal the way cli handles dependencies/injection is under discussion, so I would not rely on then.

@thgpdr it would be nice to make a test:
(1) change the order and call this._setup(this._mainStep.context) on async authorize(user) {
(2) check if it's ok to access the context using this.ctx within the authorize()

[jhomarolo]

Is this issue still valid after #85 is finished?