Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Commit f49f545

Browse files
alanbarrhishamhm
authored andcommitted
Fix printf() unsigned placeholders
Unsigned numbers should be using "%u". Raised by cppcheck
1 parent 60e5578 commit f49f545

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Process.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ void Process_humanNumber(RichString* str, unsigned long number, bool coloring) {
228228
if(number >= (10 * ONE_DECIMAL_M)) {
229229
#ifdef __LP64__
230230
if(number >= (100 * ONE_DECIMAL_G)) {
231-
len = snprintf(buffer, 10, "%4ldT ", number / ONE_G);
231+
len = snprintf(buffer, 10, "%4luT ", number / ONE_G);
232232
RichString_appendn(str, largeNumberColor, buffer, len);
233233
return;
234234
} else if (number >= (1000 * ONE_DECIMAL_M)) {
@@ -238,19 +238,19 @@ void Process_humanNumber(RichString* str, unsigned long number, bool coloring) {
238238
}
239239
#endif
240240
if(number >= (100 * ONE_DECIMAL_M)) {
241-
len = snprintf(buffer, 10, "%4ldG ", number / ONE_M);
241+
len = snprintf(buffer, 10, "%4luG ", number / ONE_M);
242242
RichString_appendn(str, largeNumberColor, buffer, len);
243243
return;
244244
}
245245
len = snprintf(buffer, 10, "%4.1lfG ", (double)number / ONE_M);
246246
RichString_appendn(str, largeNumberColor, buffer, len);
247247
return;
248248
} else if (number >= 100000) {
249-
len = snprintf(buffer, 10, "%4ldM ", number / ONE_K);
249+
len = snprintf(buffer, 10, "%4luM ", number / ONE_K);
250250
RichString_appendn(str, processMegabytesColor, buffer, len);
251251
return;
252252
} else if (number >= 1000) {
253-
len = snprintf(buffer, 10, "%2ld", number/1000);
253+
len = snprintf(buffer, 10, "%2lu", number/1000);
254254
RichString_appendn(str, processMegabytesColor, buffer, len);
255255
number %= 1000;
256256
len = snprintf(buffer, 10, "%03lu ", number);
@@ -278,7 +278,7 @@ void Process_colorNumber(RichString* str, unsigned long long number, bool colori
278278
int len = snprintf(buffer, 13, " no perm ");
279279
RichString_appendn(str, CRT_colors[PROCESS_SHADOW], buffer, len);
280280
} else if (number > 10000000000) {
281-
xSnprintf(buffer, 13, "%11lld ", number / 1000);
281+
xSnprintf(buffer, 13, "%11llu ", number / 1000);
282282
RichString_appendn(str, largeNumberColor, buffer, 5);
283283
RichString_appendn(str, processMegabytesColor, buffer+5, 3);
284284
RichString_appendn(str, processColor, buffer+8, 4);
@@ -380,9 +380,9 @@ void Process_writeField(Process* this, RichString* str, ProcessField field) {
380380
switch (field) {
381381
case PERCENT_CPU: {
382382
if (this->percent_cpu > 999.9) {
383-
xSnprintf(buffer, n, "%4d ", (unsigned int)this->percent_cpu);
383+
xSnprintf(buffer, n, "%4u ", (unsigned int)this->percent_cpu);
384384
} else if (this->percent_cpu > 99.9) {
385-
xSnprintf(buffer, n, "%3d. ", (unsigned int)this->percent_cpu);
385+
xSnprintf(buffer, n, "%3u. ", (unsigned int)this->percent_cpu);
386386
} else {
387387
xSnprintf(buffer, n, "%4.1f ", this->percent_cpu);
388388
}

0 commit comments

Comments
 (0)