Skip to content

Conversation

@hjyssg
Copy link
Owner

@hjyssg hjyssg commented Sep 29, 2025

Summary

  • add a new packages/backend_gui Electron + React application that wraps the existing backend service
  • implement configuration persistence, process lifecycle management, log streaming/rotation, health checks, and tray controls in the main process
  • build a Tailwind-based UI for configuration, service control, and log filtering plus provide packaging scripts, README, and a smoke test helper

Testing

  • not run (environment only)

https://chatgpt.com/codex/tasks/task_e_68d9f4b1dd0c83259cc2513bbef30bd9

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +302 to +305
app.on('window-all-closed', () => {
if (process.platform !== 'darwin') {
stopHealthChecks();
app.quit();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Stop backend before quitting Electron app

The quit handlers call stopHealthChecks() and app.quit() without shutting down the child process managed by ServiceManager. If the user closes the GUI while the backend is running, the spawned server keeps running in the background and continues to hold the port, defeating the purpose of the GUI wrapper. The tray “退出” item uses the same pattern a few lines above. Consider awaiting serviceManager.stop() (or otherwise killing the child) before quitting so the backend terminates with the application.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants