Skip to content

Commit 004aed6

Browse files
author
David Heinemeier Hansson
committed
Bump for Stimulus 3.2.1
1 parent f893b09 commit 004aed6

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

app/assets/javascripts/stimulus.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//= link ./stimulus-loading.js
44

55
/*
6-
Stimulus 3.2.0
6+
Stimulus 3.2.1
77
Copyright © 2022 Basecamp, LLC
88
*/
99
class EventListener {
@@ -173,13 +173,19 @@ const descriptorPattern = /^(?:(.+?)(?:\.(.+?))?(?:@(window|document))?->)?(.+?)
173173
function parseActionDescriptorString(descriptorString) {
174174
const source = descriptorString.trim();
175175
const matches = source.match(descriptorPattern) || [];
176+
let eventName = matches[1];
177+
let keyFilter = matches[2];
178+
if (keyFilter && !["keydown", "keyup", "keypress"].includes(eventName)) {
179+
eventName += `.${keyFilter}`;
180+
keyFilter = "";
181+
}
176182
return {
177183
eventTarget: parseEventTarget(matches[3]),
178-
eventName: matches[1],
184+
eventName,
179185
eventOptions: matches[6] ? parseEventOptions(matches[6]) : {},
180186
identifier: matches[4],
181187
methodName: matches[5],
182-
keyFilter: matches[2],
188+
keyFilter,
183189
};
184190
}
185191
function parseEventTarget(eventTargetName) {
@@ -255,7 +261,7 @@ class Action {
255261
return false;
256262
}
257263
if (!Object.prototype.hasOwnProperty.call(this.keyMappings, standardFilter)) {
258-
error(`contains unkown key filter: ${this.keyFilter}`);
264+
error(`contains unknown key filter: ${this.keyFilter}`);
259265
}
260266
return this.keyMappings[standardFilter].toLowerCase() !== event.key.toLowerCase();
261267
}

app/assets/javascripts/stimulus.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/assets/javascripts/stimulus.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)