-
Notifications
You must be signed in to change notification settings - Fork 151
Description
Background
IDataType is the bridge between ClickHouse type system and JDBC type system, and we find there are some limitations in current implementation, the most important one I think is the lack of Generic Type constraint. Without this constraint, serializeBinary can only accept Object, and deserializeBinary can only return Object, which causes all static type checks lose effectiveness.
The root cause here is that JDBC type and ClickHouse type are not a 1:1 mapping, and we mixed the UIntX and IntX in one DataTypeIntX make things worse. Because Java Generic Type system not support MixIn(or Hybrid) Type constraint, Object is the only option.
Another thing is that we found some JDBC-GUI Tools like DataGrip will call ResultSet#getString to render the value and display it. The temporary solution in codebase is roughly return object#toString.
Based on above, I think we need to refactor IDataType.
Proposal
- Decouple
IDataTypetype and JDBC type;
- One ClickHouse type mapping one
IDataTypewith the property Java type, i.e.DateTimemap toDataTypeDateTime(ZonedDateTime); - Introduce a converter layer between
IDataTypeand JDBC interface type, thusDataTypeDateTime(ZonedDateTime) can map tojava.sql.Date,Timestamp,Calendar;
- Split
DataTypeIntXintoDataTypeUIntXandDataTypeIntX; - Add Generic Type constraint on IDataType to get more benefits of static type checks;
- Add capability of render value to property
Stringfor display inIDataType.
After this, it will be easier to implement features like #265.
Consider this change is a bit large, it will not included in release v2.5.0.
@sundy-li @sbouchex Please let me know what you guys thinking of this proposal.
Updated
This proposal has been almost implemented in #295, and the followup PR will coming soon.