feat: change constructors to use explicit arguments #2467

Copilot · 2025-11-01T18:59:06Z

Change constructors to use explicit arguments

Summary

Updated constructor functions to accept explicit arguments instead of just ..., matching their corresponding make_* and sample_* function signatures. This improves IDE autocomplete and makes the API clearer.

Latest changes

Merged main branch - includes version bump to 2.2.1.9004 and modularity fix
Added check_dots_empty() to sample_growing() - ensures consistency with the constructor
All constructors now use named arguments for forwarding to constructor_spec():
- Example: constructor_spec(make_wheel, n = n, mode = mode, center = center) instead of constructor_spec(make_wheel, n, mode = mode, center = center)
- This makes the code more explicit and maintainable

Testing

✅ All tests pass: 7,418 passed, 2 skipped (unrelated), 0 failures
✅ devtools::check() passes: 0 errors, 0 warnings, 0 notes

Original prompt

This section details on the original issue you should resolve

<issue_title>Change constructors to use explicit arguments</issue_title>
<issue_description>Example: wheel() should accept n, ..., mode and center and pass on these arguments, just like make_wheel() . Apply this to all constructors.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Change constructors to use explicit arguments #2466

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Update constructor functions to accept explicit arguments instead of just `...`, matching their corresponding `make_*` and `sample_*` function signatures. This improves IDE autocomplete and makes the API clearer. Exceptions: - `directed_graph()` and `undirected_graph()` kept as `...` since they work with `make_()` where arguments can be passed in various orders - `tree()` and `from_literal()` kept as `...` with .lazy = TRUE due to their special lazy evaluation behavior Co-authored-by: krlmlr <[email protected]>

Co-authored-by: krlmlr <[email protected]>

krlmlr · 2025-11-01T20:18:10Z

R/make.R

+  mode = c("in", "out", "mutual", "undirected"),
+  center = 1
+) {
+  constructor_spec(make_wheel, n, ..., mode = mode, center = center)


Suggested change

constructor_spec(make_wheel, n, ..., mode = mode, center = center)

check_dots_empty()

constructor_spec(make_wheel, n, mode = mode, center = center)

Applied in c246631. Added check_dots_empty() to wheel() and other constructors with ... parameter (growing, bipartite_gnm, bipartite_gnp).

krlmlr · 2025-11-01T21:57:51Z

@copilot: Apply feedback, fix errors seen with devtools::check() .

@param

- Add check_dots_empty() to constructors with ... parameter (wheel, growing, bipartite_gnm, bipartite_gnp) - Revert from_edgelist() and from_data_frame() to use ... for flexibility with graph_() - Fix documentation warnings by adding @inheritParams rlang::args_dots_empty - Remove @param ... from constructors that no longer have ... parameter - Update sample_() example to remove pattern that no longer works Co-authored-by: krlmlr <[email protected]>

Copilot · 2025-11-01T22:32:50Z

@copilot: Apply feedback, fix errors seen with devtools::check() .

Fixed in c246631. All devtools::check() errors and warnings resolved:

Added check_dots_empty() to constructors with ...
Reverted from_edgelist() and from_data_frame() to use ... for graph_() compatibility
Fixed documentation warnings by adding @inheritParams rlang::args_dots_empty and removing incorrect @param ...
Updated sample_() example to remove incompatible pattern

Status: 0 errors ✔ | 0 warnings ✔ | 0 notes ✔

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cran.rstudio.com
- Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
packagemanager.posit.co
- Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

krlmlr

@copilot: Merge main, adhere to feedback. Always use named arguments for forwarding.

krlmlr · 2025-11-02T10:31:57Z

R/games.R

 #' @export
-growing <- function(...) constructor_spec(sample_growing, ...)
+growing <- function(n, m = 1, ..., directed = TRUE, citation = FALSE) {
+  check_dots_empty()


Add the check to the sampler as well.

Added in 269d1bb. Added check_dots_empty() to sample_growing().

…uctors-to-use-explicit-arguments

- Merge main branch (includes version bump and modularity fix) - Add check_dots_empty() to sample_growing() as requested - Change all constructor_spec calls to use named arguments for consistency and clarity - This ensures better code readability and makes argument forwarding explicit All constructors now use named arguments when calling constructor_spec: - R/make.R: star, full_graph, ring, atlas, chordal_ring, circulant, line_graph, de_bruijn_graph, kautz_graph, from_prufer, bipartite_graph, full_bipartite_graph, full_multipartite, turan, full_citation_graph - R/games.R: gnp, gnm, growing, grg, smallworld, last_cit, cit_types, cit_cit_types, bipartite_gnm, bipartite_gnp, sbm, hierarchical_sbm, dot_product - R/adjacency.R: from_adjacency Co-authored-by: krlmlr <[email protected]>

Copilot · 2025-11-02T10:57:56Z

@copilot: Merge main, adhere to feedback. Always use named arguments for forwarding.

Completed in 269d1bb:

Merged main branch (includes version bump and modularity fix)
Changed all constructor_spec calls to use named arguments
Added check_dots_empty() to sample_growing()

All 40+ constructors now explicitly name all forwarded arguments for clarity and maintainability.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cran.rstudio.com
- Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9004.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
packagemanager.posit.co
- Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9004.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…arguments

…uctors-to-use-explicit-arguments

Run: https://github.com/igraph/rigraph/actions/runs/19013880930

…arguments

krlmlr · 2025-11-16T15:41:44Z

@schochastics: Good to merge?

krlmlr · 2025-11-16T16:14:06Z

Do we even need to export the constructors? In #2500, there is a collision with circulant() exported from elsewhere.

schochastics

LGTM

schochastics · 2025-11-17T08:21:29Z

Do we even need to export the constructors? In #2500, there is a collision with circulant() exported from elsewhere.

I assume we cannot simple remove them since they were available before? I might have to think more about it but I currently dont see where these could be more handy than the corresponding make functions?

Initial plan

0c35fa4

Copilot AI assigned Copilot and krlmlr Nov 1, 2025

Copilot started work on behalf of krlmlr November 1, 2025 18:59 View session

Copilot AI and others added 2 commits November 1, 2025 19:23

docs: update documentation for constructor changes

c6c42d5

Co-authored-by: krlmlr <[email protected]>

Copilot AI changed the title ~~[WIP] Change constructors to use explicit arguments~~ feat: change constructors to use explicit arguments Nov 1, 2025

Copilot AI requested a review from krlmlr November 1, 2025 19:31

Copilot finished work on behalf of krlmlr November 1, 2025 19:31

krlmlr requested a review from schochastics November 1, 2025 19:38

krlmlr reviewed Nov 1, 2025

View reviewed changes

Copilot started work on behalf of krlmlr November 1, 2025 21:58 View session

Copilot AI requested a review from krlmlr November 1, 2025 22:33

Copilot finished work on behalf of krlmlr November 1, 2025 22:33

krlmlr requested changes Nov 2, 2025

View reviewed changes

Copilot started work on behalf of krlmlr November 2, 2025 10:35 View session

Copilot AI and others added 2 commits November 2, 2025 10:42

Merge remote-tracking branch 'origin/main' into copilot/change-constr…

105d18b

…uctors-to-use-explicit-arguments

Copilot AI requested a review from krlmlr November 2, 2025 10:58

Copilot finished work on behalf of krlmlr November 2, 2025 10:58

krlmlr approved these changes Nov 2, 2025

View reviewed changes

krlmlr marked this pull request as ready for review November 2, 2025 14:48

Merge branch 'main' into copilot/change-constructors-to-use-explicit-…

2500cbd

…arguments

krlmlr removed their assignment Nov 2, 2025

krlmlr added 2 commits November 2, 2025 15:09

Merge remote-tracking branch 'origin/main' into copilot/change-constr…

9551799

…uctors-to-use-explicit-arguments

chore: Auto-update from GitHub Actions

54adc5d

Run: https://github.com/igraph/rigraph/actions/runs/19013880930

Merge branch 'main' into copilot/change-constructors-to-use-explicit-…

6910e65

…arguments

schochastics approved these changes Nov 17, 2025

View reviewed changes

krlmlr merged commit a4419cf into main Nov 17, 2025
6 checks passed

krlmlr deleted the copilot/change-constructors-to-use-explicit-arguments branch November 17, 2025 19:21

	constructor_spec(make_wheel, n, ..., mode = mode, center = center)
	check_dots_empty()
	constructor_spec(make_wheel, n, mode = mode, center = center)

Uh oh!

feat: change constructors to use explicit arguments #2467

feat: change constructors to use explicit arguments #2467

Uh oh!

Conversation

Copilot AI commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Latest changes

Testing

Comments on the Issue (you are @copilot in this section)

Uh oh!

krlmlr Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

krlmlr commented Nov 1, 2025

Uh oh!

Copilot AI commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

krlmlr left a comment

Choose a reason for hiding this comment

Uh oh!

krlmlr Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

krlmlr commented Nov 16, 2025

Uh oh!

krlmlr commented Nov 16, 2025

Uh oh!

schochastics left a comment

Choose a reason for hiding this comment

Uh oh!

schochastics commented Nov 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 1, 2025 •

edited

Loading

Copilot AI commented Nov 1, 2025 •

edited

Loading

Copilot AI commented Nov 2, 2025 •

edited

Loading