chore: Use autogenerated _impl functions instead of .Call()
#2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…games, layout Co-authored-by: krlmlr <[email protected]>
Co-authored-by: krlmlr <[email protected]>
Copilot stopped work on behalf of
krlmlr due to an error
November 1, 2025 20:57
Contributor
|
@copilot: Resolve conflicts and proceed. |
Co-authored-by: krlmlr <[email protected]>
Contributor
Author
Copilot
AI
changed the title
[WIP] Use autogenerated _impl functions instead of .Call()
Use autogenerated _impl functions instead of .Call()
Nov 1, 2025
Copilot finished work on behalf of
krlmlr
November 1, 2025 23:04
krlmlr
requested changes
Nov 2, 2025
R/community.R
Outdated
| cli::cli_abort("Membership is not a numerical vector") | ||
| } | ||
| membership <- as.numeric(membership) | ||
| # Pre-process weights to match old behavior |
Contributor
There was a problem hiding this comment.
No more preprocessing needed, this was a bug that's now fixed in main.
Contributor
Author
There was a problem hiding this comment.
Removed weight preprocessing. The modularity_impl now handles this correctly. Fixed in 0d7575e.
R/rewire.R
Outdated
| multiple = FALSE, | ||
| mode = c("all", "out", "in", "total") | ||
| ) { | ||
| mode_char <- igraph_match_arg(mode) |
Contributor
There was a problem hiding this comment.
Rename to mode, check on strings instead of numbers.
Contributor
Author
There was a problem hiding this comment.
Renamed to mode and updated to check on strings (mode != "all" && mode != "total") instead of numeric values. Fixed in 0d7575e.
- Remove weight preprocessing in modularity.igraph (fixed in main) - Rename mode_char to mode and check strings instead of numbers in rewire.R Co-authored-by: krlmlr <[email protected]>
Contributor
Author
Copilot finished work on behalf of
krlmlr
November 2, 2025 10:43
krlmlr
changed the title
_impl functions instead of .Call()
krlmlr
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to autogenerated
_implfunctionsThis PR addresses the issue of replacing
.Call()usage with corresponding_implfunctions where they exist.Summary
Successfully replaced all 24
.Call()invocations with_implfunction calls across 11 files, maintaining original behavior while following codebase conventions.Implementation Details
_implhandle it_implfunctions now properly handle automatic weight fetching (fixed in main branch)_implfunctions handle thisFiles Changed
R/centrality.R- closeness_cutoffR/community.R- modularity, community_fluid_communitiesR/flow.R- st_mincutR/games.R- erdos_renyi_game_gnm, preference_game, asymmetric_preference_gameR/layout.R- layout_davidson_harel, layout_gem, layout_sugiyamaR/make.R- extended_chordal_ring (2 occurrences)R/rewire.R- rewire_directed_edgesR/scan.R- local_scan_* functions (8 occurrences)R/structural-properties.R- maximum_bipartite_matchingR/topology.R- get_isomorphisms_vf2, get_subisomorphisms_vf2R/hrg.R- hrg_predictR/versions.R- vcount (intentionally skipped - uses.Call()to avoid recursion)Recent Changes
modularity.igraph()(bug fixed in main)mode_chartomodeinrewire.Rand updated to check on stringsTesting
Closes #2434
Original prompt
_implfunctions instead of using `.Call() #2434✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.