Skip to content

Commit 7aff420

Browse files
committed
Remove IA2_TRACE_EXIT references
1 parent b40d09f commit 7aff420

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

cmake/define-test.cmake

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ function(define_shared_lib)
1717
set(options NEEDS_LD_WRAP NO_UBSAN)
1818
set(oneValueArgs LIBNAME PKEY)
1919
set(multiValueArgs SRCS INCLUDE_DIR UNWRAPPED_INCLUDE_DIRS
20-
UNWRAPPED_LIBRARY_DIRS UNWRAPPED_LIBS EXTRA_REWRITER_ARGS)
20+
UNWRAPPED_LIBRARY_DIRS UNWRAPPED_LIBS)
2121
cmake_parse_arguments(SHARED_LIB "${options}" "${oneValueArgs}"
2222
"${multiValueArgs}" ${ARGN})
2323

@@ -51,7 +51,6 @@ function(define_shared_lib)
5151
LIBRARIES ${SHARED_LIB_UNWRAPPED_LIBS}
5252
SOURCES ${SHARED_LIB_SRCS}
5353
INCLUDE_DIRECTORIES ${SHARED_LIB_UNWRAPPED_INCLUDE_DIRS} ${RELATIVE_INCLUDE_DIR}
54-
EXTRA_REWRITER_ARGS ${SHARED_LIB_EXTRA_REWRITER_ARGS}
5554
)
5655

5756
target_include_directories(${LIBNAME} PUBLIC
@@ -91,7 +90,7 @@ function(define_test)
9190
set(options NEEDS_LD_WRAP NOT_IN_CHECK_IA2 NO_LIBS NO_UBSAN CRITERION_TEST WITHOUT_SANDBOX TYPE_REGISTRY)
9291
set(oneValueArgs PKEY NAME)
9392
set(multiValueArgs LIBS SRCS INCLUDE_DIR
94-
UNWRAPPED_INCLUDE_DIRS UNWRAPPED_LIBRARY_DIRS UNWRAPPED_LIBS EXTRA_REWRITER_ARGS)
93+
UNWRAPPED_INCLUDE_DIRS UNWRAPPED_LIBRARY_DIRS UNWRAPPED_LIBS)
9594
cmake_parse_arguments(DEFINE_TEST "${options}" "${oneValueArgs}"
9695
"${multiValueArgs}" ${ARGN})
9796

@@ -176,7 +175,6 @@ function(define_test)
176175
LIBRARIES ${DEFINE_TEST_UNWRAPPED_LIBS} ${DEFINE_TEST_LIBS}
177176
SOURCES ${DEFINE_TEST_SRCS}
178177
INCLUDE_DIRECTORIES ${DEFINE_TEST_UNWRAPPED_INCLUDE_DIRS} ${RELATIVE_INCLUDE_DIR}
179-
EXTRA_REWRITER_ARGS ${DEFINE_TEST_EXTRA_REWRITER_ARGS}
180178
)
181179

182180
if(ADD_SANDBOX_DEP)

cmake/ia2.cmake

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function(add_ia2_compartment NAME TYPE)
2323
# Parse options
2424
set(options ENABLE_UBSAN)
2525
set(oneValueArgs PKEY)
26-
set(multiValueArgs LIBRARIES SOURCES INCLUDE_DIRECTORIES EXTRA_REWRITER_ARGS)
26+
set(multiValueArgs LIBRARIES SOURCES INCLUDE_DIRECTORIES)
2727
cmake_parse_arguments(ARG "${options}" "${oneValueArgs}"
2828
"${multiValueArgs}" ${ARGN})
2929

@@ -49,9 +49,6 @@ function(add_ia2_compartment NAME TYPE)
4949
IA2_ENABLE=1
5050
PKEY=${ARG_PKEY}
5151
)
52-
if(IA2_TRACE_EXIT)
53-
target_compile_definitions(${NAME} PRIVATE IA2_TRACE_EXIT=1)
54-
endif()
5552
set_target_properties(${NAME} PROPERTIES PKEY ${ARG_PKEY})
5653
target_compile_options(${NAME} PRIVATE
5754
"-Werror=incompatible-pointer-types"
@@ -80,7 +77,7 @@ function(add_ia2_compartment NAME TYPE)
8077

8178
if("${TYPE}" STREQUAL "EXECUTABLE")
8279
# Create and link call gates
83-
add_ia2_call_gates(${NAME} LIBRARIES ${ARG_LIBRARIES} EXTRA_REWRITER_ARGS ${ARG_EXTRA_REWRITER_ARGS})
80+
add_ia2_call_gates(${NAME} LIBRARIES ${ARG_LIBRARIES})
8481
endif()
8582
endfunction()
8683

@@ -150,9 +147,6 @@ function(create_compile_commands NAME TYPE)
150147
IA2_ENABLE=0
151148
PKEY=${ARG_PKEY}
152149
)
153-
if(IA2_TRACE_EXIT)
154-
target_compile_definitions(${COMPILE_COMMAND_TARGET} PRIVATE IA2_TRACE_EXIT=1)
155-
endif()
156150
# Copy target properties from the real target. We might need to add more properties.
157151
target_link_libraries(${COMPILE_COMMAND_TARGET} PRIVATE $<TARGET_PROPERTY:${NAME},LINK_LIBRARIES>)
158152
target_include_directories(${COMPILE_COMMAND_TARGET} PRIVATE ${INCLUDE_DIRECTORIES})

0 commit comments

Comments
 (0)