Skip to content

feat: add support for Sora service #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add support for Sora service #1454

wants to merge 3 commits into from

Conversation

@Hk-Gosuto
Copy link
Contributor

Added support for downloading videos from Sora (sora.com)

test:
https://sora.chatgpt.com/p/s_68deacf22a84819192c0c8f05a30ae01

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 4, 2025
View reviewed changes
@Myxtral
Copy link

Myxtral commented Oct 11, 2025

Why the need? Doesn't the Sora website just let you download from it already?

@Hk-Gosuto
Copy link
Contributor Author

Why the need? Doesn't the Sora website just let you download from it already?

Because Sora only allows downloads through a regular web browser. When accessed via a mobile app, the download button doesn’t work, so this PR enables video downloads in that scenario as well. It can also be used together with iOS Shortcuts for quick video downloads.

ethrydevelops
ethrydevelops reviewed Oct 18, 2025
View reviewed changes
Copy link

@ethrydevelops ethrydevelops left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to search through all the script tags. The video source is exposed in meta[property="og:video"].

@Hk-Gosuto
optimize(sora): improve video extraction and use sora.chatgpt.com
41b7e6d 
- Use sora.chatgpt.com domain for all requests
- Prioritize og:video meta tag extraction over script parsing
- Simplify fallback regex patterns and remove complex script searching
- Fix case-insensitive matching for HTML title tags
- Reduce code complexity from ~50 to ~25 lines in extraction logic
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2025
View reviewed changes
@Hk-Gosuto
fix(sora): resolve CodeQL double escaping security issue
0959b1b 
- Add conditional check before HTML entity decoding to avoid unnecessary processing
- Reorder entity replacement to process & last, preventing double-decoding
- Add support for &imputnet#39; entity (alternative single quote encoding)
- Prevent duplicate decoding by only applying fallback decoding when og:video wasn't used
- Addresses CodeQL 'Double escaping or unescaping' high severity finding
@Hk-Gosuto
Copy link
Contributor Author

You shouldn't need to search through all the script tags. The video source is exposed in meta[property="og:video"].

Thanks for pointing that out! I've updated the implementation to use the meta[property="og:video"] tag directly instead of iterating through all the script tags. This makes the code cleaner and more reliable. Appreciate the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ethrydevelops ethrydevelops ethrydevelops left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hk-Gosuto @Myxtral @ethrydevelops