Add attempt and firstAttemptTimestamp to request context (#119)

Author: longquanzheng

README.md

@@ -9,15 +9,15 @@ See [samples](https://github.com/indeedeng/iwf-java-samples) for how to use this
 ## Gradle
 ```gradle
 // https://mvnrepository.com/artifact/io.iworkflow/iwf-java-sdk
-implementation 'io.iworkflow:iwf-java-sdk:1.2.2'
+implementation 'io.iworkflow:iwf-java-sdk:1.2.3'
 ```
 ## Maven
 ```
 <!-- https://mvnrepository.com/artifact/io.iworkflow/iwf-java-sdk -->
 <dependency>
     <groupId>io.iworkflow</groupId>
     <artifactId>iwf-java-sdk</artifactId>
-    <version>1.2.2</version>
+    <version>1.2.3</version>
     <type>pom</type>
 </dependency>
 

build.gradle

@@ -150,7 +150,7 @@ signing {
 }
 
 group = "io.iworkflow"
-version = "1.2.2"
+version = "1.2.3"
 
 nexusPublishing {
     repositories {

iwf-idl

@@ -11,4 +11,12 @@ public abstract class Context {
     public abstract String getWorkflowRunId();
 
     public abstract String getWorkflowId();
+
+    // this is the start time of the first attempt of the API call. It's from ScheduledTimestamp of Cadence/Temporal activity.GetInfo
+    // require server version 1.2.2+, return -1 if server version is lower
+    public abstract Long getFirstAttemptTimestampSeconds();
+
+    // Attempt starts from 1, and increased by 1 for every retry if retry policy is specified. It's from Attempt of Cadence/Temporal activity.GetInfo
+    // require server version 1.2.2+, return -1 if server version is lower
+    public abstract int getAttempt();
 }

src/main/java/io/iworkflow/core/Context.java

@@ -47,12 +47,7 @@ public WorkflowStateStartResponse handleWorkflowStateStart(final WorkflowStateSt
         final Object input = workerOptions.getObjectEncoder().decode(stateInput, state.getWorkflowState().getInputType());
         final DataObjectsRWImpl dataObjectsRW =
                 createDataObjectsRW(req.getWorkflowType(), req.getDataObjects());
-        final Context context = ImmutableContext.builder()
-                .workflowId(req.getContext().getWorkflowId())
-                .workflowRunId(req.getContext().getWorkflowRunId())
-                .workflowStartTimestampSeconds(req.getContext().getWorkflowStartedTimestamp())
-                .stateExecutionId(req.getContext().getStateExecutionId())
-                .build();
+        final Context context = fromIdlContext(req.getContext());
         final StateLocalsImpl stateLocals = new StateLocalsImpl(toMap(null), workerOptions.getObjectEncoder());
         final Map<String, SearchAttributeValueType> saTypeMap = registry.getSearchAttributeKeyToTypeMap(req.getWorkflowType());
         final SearchAttributeRWImpl searchAttributeRW = new SearchAttributeRWImpl(saTypeMap, req.getSearchAttributes());
@@ -113,12 +108,7 @@ public WorkflowStateDecideResponse handleWorkflowStateDecide(final WorkflowState
         final DataObjectsRWImpl dataObjectsRW =
                 createDataObjectsRW(req.getWorkflowType(), req.getDataObjects());
 
-        final Context context = ImmutableContext.builder()
-                .workflowId(req.getContext().getWorkflowId())
-                .workflowRunId(req.getContext().getWorkflowRunId())
-                .workflowStartTimestampSeconds(req.getContext().getWorkflowStartedTimestamp())
-                .stateExecutionId(req.getContext().getStateExecutionId())
-                .build();
+        final Context context = fromIdlContext(req.getContext());
         final StateLocalsImpl stateLocals = new StateLocalsImpl(toMap(req.getStateLocals()), workerOptions.getObjectEncoder());
         final Map<String, SearchAttributeValueType> saTypeMap = registry.getSearchAttributeKeyToTypeMap(req.getWorkflowType());
         final SearchAttributeRWImpl searchAttributeRW = new SearchAttributeRWImpl(saTypeMap, req.getSearchAttributes());
@@ -250,4 +240,25 @@ private List<SearchAttribute> createUpsertSearchAttributes(
         });
         return sas;
     }
+
+    private Context fromIdlContext(final io.iworkflow.gen.models.Context context) {
+        int attempt = -1; //unsupported
+        if (context.getAttempt() != null) {
+            attempt = context.getAttempt();
+        }
+        long firstAttemptTimestamp = -1; //unsupported
+        if (context.getFirstAttemptTimestamp() != null) {
+            firstAttemptTimestamp = context.getFirstAttemptTimestamp();
+        }
+
+        return ImmutableContext.builder()
+                .workflowId(context.getWorkflowId())
+                .workflowRunId(context.getWorkflowRunId())
+                .workflowStartTimestampSeconds(context.getWorkflowStartedTimestamp())
+                .stateExecutionId(context.getStateExecutionId())
+                .attempt(attempt)
+                .firstAttemptTimestampSeconds(firstAttemptTimestamp)
+                .build();
+    }
 }
+

src/main/java/io/iworkflow/core/WorkerService.java

@@ -17,11 +17,24 @@ public Class<Integer> getInputType() {
 
     @Override
     public CommandRequest start(final Context context, final Integer input, Persistence persistence, final Communication communication) {
+        if (context.getAttempt() <= 0) {
+            throw new RuntimeException("attempt must be greater than zero");
+        }
+        if (context.getFirstAttemptTimestampSeconds() <= 0) {
+            throw new RuntimeException("firstAttemptTimestampSeconds must be greater than zero");
+        }
         return CommandRequest.empty;
     }
 
     @Override
     public StateDecision decide(final Context context, final Integer input, final CommandResults commandResults, Persistence persistence, final Communication communication) {
+        if (context.getAttempt() <= 0) {
+            throw new RuntimeException("attempt must be greater than zero");
+        }
+        if (context.getFirstAttemptTimestampSeconds() <= 0) {
+            throw new RuntimeException("firstAttemptTimestampSeconds must be greater than zero");
+        }
+
         final int output = input + 1;
         return StateDecision.singleNextState(BasicWorkflowState2.class, output);
     }