Allow setting nulls to data attributes (#166)

Author: longquanzheng

src/main/java/io/iworkflow/core/persistence/DataAttributesRWImpl.java

@@ -54,7 +54,7 @@ public void setDataAttribute(String key, Object value) {
         }
 
         Class<?> registeredType = keyToTypeMap.get(key);
-        if (!registeredType.isInstance(value)) {
+        if (value != null && !registeredType.isAssignableFrom(value.getClass())) {
             throw new IllegalArgumentException(String.format("Input is not an instance of class %s", registeredType.getName()));
         }
 

src/test/java/io/iworkflow/integ/RpcTest.java

@@ -45,6 +45,21 @@ public void testRPCWorkflowFunc1() throws InterruptedException {
                 RpcWorkflow.class, wfId, 10, 999);
 
         final RpcWorkflow rpcStub = client.newRpcStub(RpcWorkflow.class, wfId, "");
+
+        client.invokeRPC(rpcStub::testRpcSetDataAttribute, "test-value");
+        String value = client.invokeRPC(rpcStub::testRpcGetDataAttribute);
+        Assertions.assertEquals("test-value", value);
+        client.invokeRPC(rpcStub::testRpcSetDataAttribute, null);
+        value = client.invokeRPC(rpcStub::testRpcGetDataAttribute);
+        Assertions.assertNull(value);
+
+        client.invokeRPC(rpcStub::testRpcSetKeyword, "test-value");
+        value = client.invokeRPC(rpcStub::testRpcGetKeyword);
+        Assertions.assertEquals("test-value", value);
+        client.invokeRPC(rpcStub::testRpcSetKeyword, null);
+        value = client.invokeRPC(rpcStub::testRpcGetKeyword);
+        Assertions.assertNull(value);
+
         final Long rpcOutput = client.invokeRPC(rpcStub::testRpcFunc1, RPC_INPUT);
 
         Assertions.assertEquals(RPC_OUTPUT, rpcOutput);

src/test/java/io/iworkflow/integ/rpc/RpcWorkflow.java

@@ -59,6 +59,7 @@ public Long testRpcFunc1(Context context, String input, Persistence persistence,
         if (context.getWorkflowId().isEmpty() || context.getWorkflowRunId().isEmpty()) {
             throw new RuntimeException("invalid context");
         }
+        persistence.setDataAttribute(TEST_DATA_OBJECT_KEY, null);// test setting to null
         persistence.setDataAttribute(TEST_DATA_OBJECT_KEY, input);
         persistence.setSearchAttributeKeyword(TEST_SEARCH_ATTRIBUTE_KEYWORD, input);
         persistence.setSearchAttributeInt64(TEST_SEARCH_ATTRIBUTE_INT, RPC_OUTPUT);
@@ -111,4 +112,36 @@ public Long testRpcFunc1Readonly(Context context, String input, Persistence pers
         }
         return RPC_OUTPUT;
     }
+
+    @RPC
+    public void testRpcSetDataAttribute(Context context, String input, Persistence persistence, Communication communication) {
+        if (context.getWorkflowId().isEmpty() || context.getWorkflowRunId().isEmpty()) {
+            throw new RuntimeException("invalid context");
+        }
+        persistence.setDataAttribute(TEST_DATA_OBJECT_KEY, input);
+    }
+
+    @RPC
+    public String testRpcGetDataAttribute(Context context, Persistence persistence, Communication communication) {
+        if (context.getWorkflowId().isEmpty() || context.getWorkflowRunId().isEmpty()) {
+            throw new RuntimeException("invalid context");
+        }
+        return persistence.getDataAttribute(TEST_DATA_OBJECT_KEY, String.class);
+    }
+
+    @RPC
+    public void testRpcSetKeyword(Context context, String input, Persistence persistence, Communication communication) {
+        if (context.getWorkflowId().isEmpty() || context.getWorkflowRunId().isEmpty()) {
+            throw new RuntimeException("invalid context");
+        }
+        persistence.setSearchAttributeKeyword(TEST_SEARCH_ATTRIBUTE_KEYWORD, input);
+    }
+
+    @RPC
+    public String testRpcGetKeyword(Context context, Persistence persistence, Communication communication) {
+        if (context.getWorkflowId().isEmpty() || context.getWorkflowRunId().isEmpty()) {
+            throw new RuntimeException("invalid context");
+        }
+        return persistence.getSearchAttributeKeyword(TEST_SEARCH_ATTRIBUTE_KEYWORD);
+    }
 }