-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(inputs.timex): Add plugin #17831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks so much for the pull request! |
|
!signed-cla |
a5f679c to
275e802
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution @HappyTobi! Please find my comments in the code.
1646d7b to
c309c3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HappyTobi! Some more minor comments...
Co-authored-by: Sven Rebhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HappyTobi! Just some formatting comments and a question regarding the frequency field left...
|
Reading more deeply into the matter, Furthermore,
What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @HappyTobi! Some last, really cosmetric, comments from my side...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot @HappyTobi for working with me on this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HappyTobi Thanks! A couple of minor comments.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HappyTobi Thanks for the contribution!
Summary
I created a new input plugin to be able to get / measure the time drifts from a Linux system to the configured ntp server.
The benefit of the plugin is, that we get the metrics from the Linux Kernel directly.
So you will get the time metrics when you are using systemd, chrony or ndpt because all the tools are calling the kernel.
As an background:
The metric can help to detect time drifts in a VM from the configure NTP server.
The metrics can also help to improve / finde issues for example with the current chrony settings because you can see the time drifts and you now have the possibility to understand them better.
Checklist
Related issues