-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Potential Issue
This issue is more of a reminder in case in the future we desire a more reactive value-sync algorithm.
By reactive we mean, that value sync immediately requests for values whenever it can actual request for more values. Currently, after these changes, value sync only requests for values during on_tick and on_status. In this cases, we request as much values as we possibly can without overflowing the sync_input_queue from core-consensus. Nevertheless, this means, that if we receive back a value response and even though we might be able to immediately request more values, we still wait until a Tick triggers (i.e., on_tick is called) or we get a Status update (i.e., on_status is called). This means, that value sync is not as reactive as possible.
Potential Solution
Whenever we remove elements from pending_consensus_requests and inflight_requests queues, we can trigger request_values in case some peer has a higher tip_height than ours.