Skip to content

Conversation

@ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Nov 10, 2025

Resolves #2865


Before the change?

  • With true it removes labels which were set manually but didn't follow patterns.

Addresses removal of label we see there #2852

After the change?

  • Keep labels which were set manually or do not match anymore changes. We may change it in the future to true if agreed to follow more strict naming of branches

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@ViacheslavKudinov
Copy link
Contributor Author

Hi @nickfloyd
to address removal of Labels set manually

@nickfloyd
Copy link
Contributor

Thank you for this follow up.. I had to disable the workflow.

@nickfloyd nickfloyd merged commit 66b1d20 into integrations:main Nov 10, 2025
3 checks passed
@ViacheslavKudinov
Copy link
Contributor Author

ViacheslavKudinov commented Nov 10, 2025

Thank you for this follow up.. I had to disable the workflow.

Yeh, I saw.

Sorry for the side effect and you are welcome.

Please tag me if any errors/bugs with Actions, i will address and fix as soon i can 🙏🏻

@ViacheslavKudinov
Copy link
Contributor Author

@nickfloyd I believe it (Labeler wf) can be enabled back.

I tested on my fork and it doesn't remove anymore the labels which were set manually and are not in configuration.

@ViacheslavKudinov
Copy link
Contributor Author

Hi,
optional one if we need to make is more precise #2883

@nickfloyd
Copy link
Contributor

@nickfloyd I believe it (Labeler wf) can be enabled back.
@ViacheslavKudinov Let me re-enable it and I'll let you know if we run into any bumps. ❤️

@ViacheslavKudinov
Copy link
Contributor Author

@nickfloyd I believe it (Labeler wf) can be enabled back.
@ViacheslavKudinov Let me re-enable it and I'll let you know if we run into any bumps. ❤️

If more than one label on PR it may appear more than once on release note for several categories,
e.g.
if there are 2 labels Type: Documentation and Type: Feature
PR may come in release note under 🛠️ Maintenance and 📝 Documentation.

But it can be fine. Just we may expect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAINT]: Improve efficiency for generating release notes

2 participants