Skip to content

fix(deps)!: upgrade rimraf addressing upstream warnings #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(deps)!: upgrade rimraf addressing upstream warnings #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbdfb8e
chore(deps): Bump rimraf to v4
anomiex Mar 26, 2025
3b432c0
Update package.json engines per request
anomiex May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const {promisify} = require('util')
/* Shallow clone so we can promisify in-place */
const fs = { ...require('fs') }
const {spawn} = require('cross-spawn')
const rimraf = promisify(require('rimraf'))
const rimraf = require('rimraf')
const pMap = require('p-map')

const _nodes = Symbol('nodes')
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"cross-spawn": "^7.0.3",
"istanbul-lib-coverage": "^3.2.0",
"p-map": "^3.0.0",
"rimraf": "^3.0.0",
"rimraf": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow turnaround on this review, if you don't mind also add this to package.json:

  "engines": {
    "node": ">=14"
  },

I can take it from there.

"uuid": "^8.3.2"
},
"devDependencies": {
Expand All @@ -27,7 +27,7 @@
"nyc": "^15.1.0"
},
"engines": {
"node": ">=8"
"node": ">=14"
},
"tap": {
"check-coverage": true,
Expand Down