Use of deprecated glob and rimraf dependencies

[jwasnoggin]

When installing nyc there are a number of npm warnings about deprecated packages:

$ npm i -D nyc 
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

It looks like glob is only used in tests, so maybe this should be moved to devDependencies?

Usages of rimraf will need to be modified slightly but this doesn't look too onerous.

inflight is only used as a dependency of the other two.

Environment Information

  System:
    OS: Linux 6.8 Fedora Linux 38 (Workstation Edition)
    CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
    Memory: 3.95 GB / 15.46 GB
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  npmPackages:
    nyc: ^15.1.0 => 15.1.0 
    ts-node: ^10.9.2 => 10.9.2 
    typescript: ^5.4.5 => 5.4.5 

[DinoChiesa]

It's complicated. rimraf is used directly by nyc, but also in various modules that are dependencies of nyc. Including istanbul-lib-processinfo, which itself has a devDependency on nyc.

$ npm list rimraf
nyc@17.0.0 /Users/dev/istanbuljs/nyc
├─┬ istanbul-lib-processinfo@2.0.3
│ └── rimraf@3.0.2 deduped
├── rimraf@3.0.2
├─┬ spawn-wrap@2.0.0
│ └── rimraf@3.0.2 deduped
├─┬ standard@14.3.4
│ └─┬ eslint@6.8.0
│   └─┬ file-entry-cache@5.0.1
│     └─┬ flat-cache@2.0.1
│       └── rimraf@2.6.3
└─┬ tap@18.8.0
  ├─┬ @tapjs/fixture@1.2.22
  │ └── rimraf@5.0.10
  ├─┬ @tapjs/run@1.5.4
  │ ├─┬ c8@8.0.1
  │ │ └── rimraf@3.0.2 deduped
  │ └── rimraf@5.0.10
  └─┬ @tapjs/test@1.4.4
    ├── rimraf@5.0.10
    ├─┬ sync-content@1.0.2
    │ └── rimraf@5.0.10
    └─┬ tshy@1.18.0
      └── rimraf@5.0.10

So basically you have a hairball to untangle here.

[anomiex]

There's not really a hairball, just some dependent packages that need updating too. But it needs someone to actually do it.

If the linked v3-to-v4 section is comprehensive, it looks like the only breaking change is that the default export changed from callback-style to Promise. But everything in nyc and istanbul-lib-processinfo using the async rimraf function is already doing promisify(require('rimraf')), so all that should be needed is removing the promisify call. spawn-wrap doesn't use the async function at all, only the sync function.

Note we don't really need to worry about dev-dependencies like standard or tap, since those don't get installed when someone does npm i -D nyc.

I made PRs to perform the needed updates. Anyone know who maintainers are who might review and merge them, and make the necessary releases?
#1591
istanbuljs/istanbul-lib-processinfo#26
istanbuljs/spawn-wrap#126

[frattaro]

@bcoe gave me a hand last time I took an interest in nyc

[jdmarshall]

What about glob?

[Lucas-C]

What about glob?

I tried using a dependency override like this:

    "pnpm": {
        "overrides": {
            "glob": "^11.0.0"
        }
    }

The result was this error:

$ pnpm nyc report
node:internal/errors:541
      throw error;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "original" argument must be of type function. Received an instance of Object
    at promisify (node:internal/util:400:3)
    at Object.<anonymous> (/tmp/node_modules/.pnpm/nyc@17.1.0/node_modules/nyc/index.js:10:14)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/tmp/node_modules/.pnpm/nyc@17.1.0/node_modules/nyc/bin/nyc.js:8:13)
    at Module._compile (node:internal/modules/cjs/loader:1469:14) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v20.18.0

So it seems that nyc is currently not compatible with glob@^11.0.0

[jwasnoggin]

In #1591 it uses glob 9 which is not deprecated, so presumably that one works?

[Lucas-C]

In #1591 it uses glob 9 which is not deprecated, so presumably that one works?

Yes, using glob@^9.0.0 is fine 👍