feat: add json struct tags to PublicCodeV0 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add json struct tags so we can serialize the struct to JSON and use it to pass the data around from the Go code to the various language bindings as a simple char*, instead of wrapping the whole type. Unfortunately the yaml library doesn't allow us to use the same tag, and we end up duplicating them: go-yaml/yaml#424 This duplication should be temporary, as goccy/go-yaml supports the json tags for YAML serialization (italia#221).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add json struct tags so we can serialize the struct to JSON and use it to pass the data around from the Go code to the various language bindings as a simple char*, instead of wrapping the whole type.
Unfortunately the yaml library doesn't allow us to use the same tag, and we end up duplicating them:
go-yaml/yaml#424
This duplication should be temporary, as goccy/go-yaml supports the json tags for YAML serialization (#221).