chore: combine airdrop farming PRs #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the following fixes: - PR #357: Replace SuperAdminCanSpendAnything with SuperAdminCanExecuteEverything in setCallChecker - PR #314: Fix typos across codebase (overriden→overridden, Calcualated→Calculated, etc.) - PR #379: Correct inline comment about approval amount (20-byte all-ones, not type(uint256).max) Co-Authored-By: GarmashAlex <[email protected]> Co-Authored-By: sukrucildirr <[email protected]> Co-Authored-By: Forostovec <[email protected]> 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
legion2002
changed the title
…ated: IthacaAccount
|
🤖 Bytecode changes detected! EIP-712 domain versions have been automatically updated for: IthacaAccount |
howydev
approved these changes
Sep 22, 2025
howydev
reviewed
Sep 22, 2025
| mstore(m, 0x095ea7b3) // `approve(address,uint256)`. | ||
| mstore(add(m, 0x20), caller()) | ||
| mstore(add(m, 0x40), 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF) // type(uint256).max | ||
| mstore(add(m, 0x40), 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF) // 20-byte all-ones sentinel (2^160-1), not uint256 max |
There was a problem hiding this comment.
took a look at the other PR - theres 42 F's here so this is actually u168max, not u160max
im fine with either changing this to 40 F's, or changing the comment to u168max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the following airdrop farming PRs, into a single PR