Update Ruff to >=0.13 and simplify configs #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Oct 31, 2025
Comment on lines
+54
to
+55
| # Deprecated rules must now be selected by exact rule code | ||
| "ruff >= 0.13; sys_platform != 'cygwin'", |
Contributor
Author
There was a problem hiding this comment.
Alternatively, this can be set directly in ruff.toml with required-version. The UX is not great as it fails at runtime telling you to bust your cache, also astral-sh/ruff#19922
Avasam
commented
Oct 31, 2025
| "UP043", # unnecessary-default-type-args | ||
|
|
||
| # Code modernization (strings, annotations, conditions, ...) | ||
| "UP", # pyupgrade |
Contributor
Author
There was a problem hiding this comment.
Alternatively:
"C901", # complex-structure
"I", # isort
"PERF401", # manual-list-comprehension
"UP", # pyupgrade (Code modernization for strings, annotations, conditions, ...)
# Ensure modern type annotation syntax and best practices
# Not including those covered by type-checkers or exclusive to Python 3.11+
"FA", # flake8-future-annotations
"F404", # late-future-import
"PYI", # flake8-pyi
Avasam
force-pushed
the
update-ruff-and-simplify-configs
branch
from
c5b6780 to
16bc2dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as for pypa/setuptools#4886
Do test on some repos with lots of string formatting, f-string (UP032) is not necessarily a rule you may want to enforce all the time.
Reduced the
conflicting-lint-rulessection to only the codes for which you'd enable the entire group in parallel. Because the baseEandFrules in defaultselectare already non-conflicting and we useextend-selectto start from said base.