(feat): support JS & JSX files in tsdx test #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JS & JSX are already supported in tsdx build, so this is just adding
some better parity in tsdx test
- more JS & JSX support also means better support for gradual TS
migrations
- JS + JSX spec files should also be ran, not just TS + TSX
- run them with babel-jest, which is jest's default
- changing transform meant babel-jest wasn't run on them anymore
- notably, TSDX itself has tests written in JS, so TSDX would need
this to dogfood itself
- also get coverage from JS + JSX files too
This was referenced Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS & JSX are already supported in tsdx build, so this is just adding
some better parity in tsdx test
migrations
JS + JSX spec files should also be ran, not just TS + TSX
this to dogfood itself
also get coverage from JS + JSX files too
I'm currently adding TSDX in https://github.com/agilgur5/react-signature-canvas while migrating it to TS and these all came up as frustrations. Related to #383 which is also about parity for build vs. test
EDIT: For posterity, here's my PR agilgur5/react-signature-canvas#42, and specifically agilgur5/react-signature-canvas@8f124fe is where this popped up.
EDIT: This apparently fixes #187 , didn't know about that issue when I wrote this