Skip to content

Commit 43cd208

Browse files
mmazasmmazas
authored andcommitted
Minor changes.
Signed-off-by: mmazas <[email protected]>
1 parent 6509a8d commit 43cd208

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

src/main/java/org/javacc/cpp/NodeFiles.java

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ private static void generateNodeHeader(final JJTreeContext context) {
8989
final CodeGeneratorSettings optionMap = CodeGeneratorSettings.of(Options.getOptions());
9090
optionMap.set("PARSER_NAME", JJTreeGlobals.parserName);
9191
optionMap.set("VISITOR_RETURN_TYPE", NodeFiles.getVisitorReturnType());
92-
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorArgumentType());
92+
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorDataType());
9393
optionMap.set(
9494
"VISITOR_RETURN_TYPE_VOID",
9595
Boolean.valueOf(NodeFiles.getVisitorReturnType().equals("void")));
@@ -118,7 +118,7 @@ private static void generateSimpleNode(final JJTreeContext context) {
118118
final CodeGeneratorSettings optionMap = CodeGeneratorSettings.of(Options.getOptions());
119119
optionMap.set(Options.NUO__PARSER_NAME, JJTreeGlobals.parserName);
120120
optionMap.set("VISITOR_RETURN_TYPE", NodeFiles.getVisitorReturnType());
121-
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorArgumentType());
121+
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorDataType());
122122
optionMap.set(
123123
"VISITOR_RETURN_TYPE_VOID",
124124
Boolean.valueOf(NodeFiles.getVisitorReturnType().equals("void")));
@@ -150,7 +150,7 @@ private static void generateOneTree(
150150
final CodeGeneratorSettings optionMap = CodeGeneratorSettings.of(Options.getOptions());
151151
optionMap.set("PARSER_NAME", JJTreeGlobals.parserName);
152152
optionMap.set("VISITOR_RETURN_TYPE", NodeFiles.getVisitorReturnType());
153-
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorArgumentType());
153+
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorDataType());
154154
optionMap.set(
155155
"VISITOR_RETURN_TYPE_VOID",
156156
Boolean.valueOf(NodeFiles.getVisitorReturnType().equals("void")));
@@ -204,7 +204,7 @@ private static void generateMultiTree(final JJTreeContext context) {
204204
final File file =
205205
new File(
206206
// new File(
207-
context.treeOptions().getASTNodeDirectory(),
207+
context.treeOptions().getNodeDirectory(),
208208
// context.treeOptions().getNodePackage()),
209209
node + ".cc");
210210
if (file.exists()) {
@@ -214,7 +214,7 @@ private static void generateMultiTree(final JJTreeContext context) {
214214
final CodeGeneratorSettings optionMap = CodeGeneratorSettings.of(Options.getOptions());
215215
optionMap.set(Options.NUO__PARSER_NAME, JJTreeGlobals.parserName);
216216
optionMap.set("VISITOR_RETURN_TYPE", NodeFiles.getVisitorReturnType());
217-
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorArgumentType());
217+
optionMap.set("VISITOR_DATA_TYPE", NodeFiles.getVisitorDataType());
218218
optionMap.set(
219219
"VISITOR_RETURN_TYPE_VOID",
220220
Boolean.valueOf(NodeFiles.getVisitorReturnType().equals("void")));
@@ -318,9 +318,13 @@ private static String getVisitMethodName(final String className) {
318318
return sb.toString();
319319
}
320320

321-
private static String getVisitorArgumentType() {
321+
private static String getVisitorDataType() {
322322
final String ret = Options.stringValue("VISITOR_DATA_TYPE");
323-
return (ret == null) || ret.equals("") || ret.equals("Object") ? "void *" : ret;
323+
return (ret == null || ret.equals("") || ret.equals("Object")) ? "void*" : ret;
324+
}
325+
326+
private static boolean getVisitorDataTypeIsPointer() {
327+
return Options.booleanValue("VISITOR_DATA_TYPE_IS_POINTER");
324328
}
325329

326330
private static String getVisitorReturnType() {
@@ -368,7 +372,7 @@ private static void generateVisitorInterface(
368372
ccb.println("class " + name);
369373
ccb.println("{");
370374

371-
String argumentType = NodeFiles.getVisitorArgumentType();
375+
String argumentType = NodeFiles.getVisitorDataType();
372376
final String returnType = NodeFiles.getVisitorReturnType();
373377
if (!context.treeOptions().getVisitorDataType().equals("")) {
374378
argumentType = context.treeOptions().getVisitorDataType();
@@ -411,7 +415,7 @@ private static void generateDefaultVisitor(
411415

412416
ccb.println("class " + className + " : public " + NodeFiles.visitorClass() + " {");
413417

414-
final String argumentType = NodeFiles.getVisitorArgumentType();
418+
final String argumentType = NodeFiles.getVisitorDataType();
415419
final String ret = NodeFiles.getVisitorReturnType();
416420

417421
ccb.println("public:");

src/main/resources/templates/cpp/MultiNode.cc.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace ${NAMESPACE_OPEN}
4444
${NODE_TYPE}::~${NODE_TYPE}() {}
4545

4646
#if VISITOR
47-
/** Accept the visitor. **/
47+
/** Accept the visitor. */
4848
${VISITOR_RETURN_TYPE} ${NODE_TYPE}::jjtAccept(${PARSER_NAME}Visitor *visitor, ${VISITOR_DATA_TYPE:-void *} data) const {
4949
#if !VISITOR_RETURN_TYPE_VOID
5050
return

src/main/resources/templates/cpp/MultiNode.h.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public:
5050
virtual ~${NODE_TYPE}();
5151

5252
#if VISITOR
53-
/** Accept the visitor. **/
53+
/** Accept the visitor. */
5454
virtual ${VISITOR_RETURN_TYPE} jjtAccept(${PARSER_NAME}Visitor* visitor, ${VISITOR_DATA_TYPE:-void*} data) const ;
5555
#fi
5656
};

0 commit comments

Comments
 (0)