Skip to content

drop the .promise method #4

@tunnckoCore

Description

@tunnckoCore

Or use some promise lib or do some workaround. Currently it calls the glob.sync method which not make any sense - so, something like async response/method sync operation. With that .promise method you just return a promise, but actually behind the scenes everything is sync, nothing is async. Does make users think they really do some async operation, because they got promise, but in real it's not async.

Hope you got correctly my state. Just noticed some things and share thoughts. Dropping it make more sense instead as it is currently. Or at least, make a not on readme, imho.

Cheers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions