Adjust device type exception to be a specific feature exception

Author: jpelgrom

letpot/converters.py

@@ -8,7 +8,7 @@
 
 from aiomqtt.types import PayloadType
 
-from letpot.exceptions import LetPotDeviceTypeException, LetPotException
+from letpot.exceptions import LetPotDeviceCategoryException, LetPotException
 from letpot.models import (
     CycleWateringMode,
     DeviceFeature,
@@ -117,7 +117,7 @@ def get_current_status_message(self) -> list[int]:
 
     def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
         if not isinstance(status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         return [
             97,
             2,
@@ -196,7 +196,7 @@ def get_current_status_message(self) -> list[int]:
 
     def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
         if not isinstance(status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         return [
             11,
             2,
@@ -271,7 +271,7 @@ def get_current_status_message(self) -> list[int]:
 
     def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
         if not isinstance(status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         return [
             13,
             2,
@@ -354,7 +354,7 @@ def get_current_status_message(self) -> list[int]:
 
     def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
         if not isinstance(status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         return [
             101,
             2,
@@ -426,7 +426,7 @@ def get_current_status_message(self) -> list[int]:
 
     def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
         if not isinstance(status, LetPotWateringSystemStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         return [
             65,
             2,

letpot/deviceclient.py

@@ -18,7 +18,7 @@
 from letpot.exceptions import (
     LetPotAuthenticationException,
     LetPotConnectionException,
-    LetPotDeviceTypeException,
+    LetPotDeviceCategoryException,
     LetPotException,
     LetPotFeatureException,
 )
@@ -410,7 +410,7 @@ async def set_light_brightness(self, serial: str, level: int) -> None:
 
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, light_brightness=level)
         await self._publish_status(serial, status)
 
@@ -419,7 +419,7 @@ async def set_light_mode(self, serial: str, mode: LightMode) -> None:
         """Set the light mode for this device (flower/vegetable)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, light_mode=mode)
         await self._publish_status(serial, status)
 
@@ -430,7 +430,7 @@ async def set_light_schedule(
         """Set the light schedule for this device (start time and/or end time)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         start_time = use_status.light_schedule_start if start is None else start
         end_time = use_status.light_schedule_end if end is None else end
         status = dataclasses.replace(
@@ -445,7 +445,7 @@ async def set_plant_days(self, serial: str, days: int) -> None:
         """Set the plant days counter for this device (number of days)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, plant_days=days)
         await self._publish_status(serial, status)
 
@@ -454,7 +454,7 @@ async def set_power(self, serial: str, on: bool) -> None:
         """Set the general power for this device (on/off)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, system_on=on)
         await self._publish_status(serial, status)
 
@@ -470,7 +470,7 @@ async def set_sound(self, serial: str, on: bool) -> None:
         """Set the alarm sound for this device (on/off)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, system_sound=on)
         await self._publish_status(serial, status)
 
@@ -479,7 +479,7 @@ async def set_temperature_unit(self, serial: str, unit: TemperatureUnit) -> None
         """Set the temperature unit for this device (Celsius/Fahrenheit)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, temperature_unit=unit)
         await self._publish_status(serial, status)
 
@@ -488,7 +488,7 @@ async def set_water_mode(self, serial: str, on: bool) -> None:
         """Set the automatic water/nutrient mode for this device (on/off)."""
         use_status = self._get_publish_status(serial)
         if not isinstance(use_status, LetPotGardenStatus):
-            raise LetPotDeviceTypeException()
+            raise LetPotDeviceCategoryException()
         status = dataclasses.replace(use_status, water_mode=1 if on else 0)
         await self._publish_status(serial, status)
 

letpot/exceptions.py

@@ -13,9 +13,9 @@ class LetPotAuthenticationException(LetPotException):
     """LetPot authentication exception."""
 
 
-class LetPotDeviceTypeException(LetPotException):
-    """LetPot incorrect device type exception."""
-
-
 class LetPotFeatureException(LetPotException):
     """LetPot device feature exception."""
+
+
+class LetPotDeviceCategoryException(LetPotFeatureException):
+    """LetPot incorrect device type exception."""