Skip to content

Commit 7a83c67

Browse files
committed
docs: the returned geometries are not always new
1 parent 35217fe commit 7a83c67

File tree

12 files changed

+24
-24
lines changed

12 files changed

+24
-24
lines changed

packages/modeling/src/operations/booleans/intersect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import intersectGeom2 from './intersectGeom2.js'
88
import intersectGeom3 from './intersectGeom3.js'
99

1010
/**
11-
* Return a new geometry representing space in both the first geometry and
11+
* Return a geometry representing space in both the first geometry and
1212
* all subsequent geometries.
1313
* The given geometries should be of the same type, either geom2 or geom3.
1414
*
1515
* @param {...Object} geometries - list of geometries
16-
* @returns {geom2|geom3} a new geometry
16+
* @returns {geom2|geom3} a geometry
1717
* @alias module:modeling/booleans.intersect
1818
*
1919
* @example

packages/modeling/src/operations/booleans/intersectGeom2.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { INTERSECTION } from './martinez/operation.js'
44
import boolean from './martinez/index.js'
55

66
/*
7-
* Return a new 2D geometry representing space in both the first geometry and
7+
* Return a 2D geometry representing space in both the first geometry and
88
* in the subsequent geometries. None of the given geometries are modified.
99
* @param {...geom2} geometries - list of 2D geometries
10-
* @returns {geom2} new 2D geometry
10+
* @returns {geom2} a 2D geometry
1111
*/
1212
export const intersectGeom2 = (...geometries) => {
1313
geometries = flatten(geometries)

packages/modeling/src/operations/booleans/intersectGeom3.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import retessellate from '../modifiers/retessellate.js'
55
import intersectSub from './intersectGeom3Sub.js'
66

77
/*
8-
* Return a new 3D geometry representing space in both the first geometry and
8+
* Return a 3D geometry representing space in both the first geometry and
99
* in the subsequent geometries. None of the given geometries are modified.
1010
* @param {...geom3} geometries - list of 3D geometries
11-
* @returns {geom3} new 3D geometry
11+
* @returns {geom3} a 3D geometry
1212
*/
1313
export const intersectGeom3 = (...geometries) => {
1414
geometries = flatten(geometries)

packages/modeling/src/operations/booleans/intersectGeom3Sub.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ import { Tree } from './trees/index.js'
55
import mayOverlap from './mayOverlap.js'
66

77
/*
8-
* Return a new 3D geometry representing the space in both the first geometry and
8+
* Return a 3D geometry representing the space in both the first geometry and
99
* the second geometry. None of the given geometries are modified.
1010
* @param {geom3} geometry1 - a geometry
1111
* @param {geom3} geometry2 - a geometry
12-
* @returns {geom3} new 3D geometry
12+
* @returns {geom3} a 3D geometry
1313
*/
1414
export const intersectGeom3Sub = (geometry1, geometry2) => {
1515
if (!mayOverlap(geometry1, geometry2)) {

packages/modeling/src/operations/booleans/subtract.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import subtractGeom2 from './subtractGeom2.js'
88
import subtractGeom3 from './subtractGeom3.js'
99

1010
/**
11-
* Return a new geometry representing space in the first geometry but
11+
* Return a geometry representing space in the first geometry but
1212
* not in all subsequent geometries.
1313
* The given geometries should be of the same type, either geom2 or geom3.
1414
*
1515
* @param {...Object} geometries - list of geometries
16-
* @returns {geom2|geom3} a new geometry
16+
* @returns {geom2|geom3} a geometry
1717
* @alias module:modeling/booleans.subtract
1818
*
1919
* @example

packages/modeling/src/operations/booleans/subtractGeom2.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { DIFFERENCE } from './martinez/operation.js'
44
import boolean from './martinez/index.js'
55

66
/*
7-
* Return a new 2D geometry representing space in the first geometry but
7+
* Return a 2D geometry representing space in the first geometry but
88
* not in the subsequent geometries. None of the given geometries are modified.
99
* @param {...geom2} geometries - list of geometries
10-
* @returns {geom2} new 2D geometry
10+
* @returns {geom2} a 2D geometry
1111
*/
1212
export const subtractGeom2 = (...geometries) => {
1313
geometries = flatten(geometries)

packages/modeling/src/operations/booleans/subtractGeom3.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import retessellate from '../modifiers/retessellate.js'
55
import subtractSub from './subtractGeom3Sub.js'
66

77
/*
8-
* Return a new 3D geometry representing space in this geometry but not in the given geometries.
8+
* Return a 3D geometry representing space in this geometry but not in the given geometries.
99
* Neither this geometry nor the given geometries are modified.
1010
* @param {...geom3} geometries - list of geometries
11-
* @returns {geom3} new 3D geometry
11+
* @returns {geom3} a 3D geometry
1212
*/
1313
export const subtractGeom3 = (...geometries) => {
1414
geometries = flatten(geometries)

packages/modeling/src/operations/booleans/subtractGeom3Sub.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ import { Tree } from './trees/index.js'
55
import mayOverlap from './mayOverlap.js'
66

77
/*
8-
* Return a new 3D geometry representing the space in the first geometry but not
8+
* Return a 3D geometry representing the space in the first geometry but not
99
* in the second geometry. None of the given geometries are modified.
1010
* @param {geom3} geometry1 - a geometry
1111
* @param {geom3} geometry2 - a geometry
12-
* @returns {geom3} new 3D geometry
12+
* @returns {geom3} a 3D geometry
1313
*/
1414
export const subtractGeom3Sub = (geometry1, geometry2) => {
1515
if (!mayOverlap(geometry1, geometry2)) {

packages/modeling/src/operations/booleans/union.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import unionGeom2 from './unionGeom2.js'
88
import unionGeom3 from './unionGeom3.js'
99

1010
/**
11-
* Return a new geometry representing the total space in the given geometries.
11+
* Return a geometry representing the total space in the given geometries.
1212
* The given geometries should be of the same type, either geom2 or geom3.
1313
*
1414
* @param {...Object} geometries - list of geometries
15-
* @returns {geom2|geom3} a new geometry
15+
* @returns {geom2|geom3} a geometry
1616
* @alias module:modeling/booleans.union
1717
*
1818
* @example

packages/modeling/src/operations/booleans/unionGeom2.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { UNION } from './martinez/operation.js'
44
import boolean from './martinez/index.js'
55

66
/*
7-
* Return a new 2D geometry representing the total space in the given 2D geometries.
7+
* Return a 2D geometry representing the total space in the given 2D geometries.
88
* @param {...geom2} geometries - list of 2D geometries to union
9-
* @returns {geom2} new 2D geometry
9+
* @returns {geom2} a 2D geometry
1010
*/
1111
export const unionGeom2 = (...geometries) => {
1212
geometries = flatten(geometries)

0 commit comments

Comments
 (0)