Skip to content

Commit a0506d1

Browse files
committed
No geometry clone
1 parent 639d7af commit a0506d1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+25
-268
lines changed

packages/modeling/src/colors/colorize.js

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,19 @@ import * as path2 from '../geometries/path2/index.js'
66
import * as poly3 from '../geometries/poly3/index.js'
77

88
const colorGeom2 = (color, object) => {
9-
const newGeom2 = geom2.clone(object)
10-
newGeom2.color = color
11-
return newGeom2
9+
return Object.assign({}, object, { color })
1210
}
1311

1412
const colorGeom3 = (color, object) => {
15-
const newGeom3 = geom3.clone(object)
16-
newGeom3.color = color
17-
return newGeom3
13+
return Object.assign({}, object, { color })
1814
}
1915

2016
const colorPath2 = (color, object) => {
21-
const newPath2 = path2.clone(object)
22-
newPath2.color = color
23-
return newPath2
17+
return Object.assign({}, object, { color })
2418
}
2519

2620
const colorPoly3 = (color, object) => {
27-
const newPoly = poly3.clone(object)
28-
newPoly.color = color
29-
return newPoly
21+
return Object.assign({}, object, { color })
3022
}
3123

3224
/**

packages/modeling/src/connectors/create.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ import * as vec3 from '../maths/vec3/index.js'
1818
* @example
1919
* let myConnector = create()
2020
*/
21-
export const create = () => ({ point: vec3.create(), axis: vec3.clone([0, 0, 1]), normal: vec3.clone([1, 0, 0]) })
21+
export const create = () => ({ point: vec3.create(), axis: [0, 0, 1], normal: [1, 0, 0] })

packages/modeling/src/geometries/geom2/clone.d.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/modeling/src/geometries/geom2/clone.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/modeling/src/geometries/geom2/clone.test.js

Lines changed: 0 additions & 26 deletions
This file was deleted.

packages/modeling/src/geometries/geom2/fromCompactBinary.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const fromCompactBinary = (data) => {
1414

1515
const created = create()
1616

17-
created.transforms = mat4.clone(data.slice(1, 17))
17+
created.transforms = data.slice(1, 17)
1818

1919
for (let i = 21; i < data.length;) {
2020
const length = data[i++] // number of points for this polygon

packages/modeling/src/geometries/geom2/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
export { clone } from './clone'
21
export { create } from './create'
32
export { fromSides } from './fromSides'
43
export { fromCompactBinary } from './fromCompactBinary'

packages/modeling/src/geometries/geom2/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
* import { geometries } from '@jscad/modeling'
99
* let myShape = geometries.geom2.create([ [[-1,-1], [1,-1], [1,1], [-1,1]] ])
1010
*/
11-
export { clone } from './clone.js'
1211
export { create } from './create.js'
1312
export { fromSides } from './fromSides.js'
1413
export { fromCompactBinary } from './fromCompactBinary.js'

packages/modeling/src/geometries/geom2/reverse.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { clone } from './clone.js'
21

32
/**
43
* Reverses the given geometry so that the outline points are flipped in the opposite order.
@@ -11,7 +10,7 @@ import { clone } from './clone.js'
1110
* let newGeometry = reverse(geometry)
1211
*/
1312
export const reverse = (geometry) => {
14-
const reversed = clone(geometry)
13+
const reversed = Object.assign({}, geometry)
1514
reversed.outlines = reversed.outlines.map((outline) => outline.slice().reverse())
1615
return reversed
1716
}

packages/modeling/src/geometries/geom3/clone.d.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)