Skip to content

Commit b32dcce

Browse files
authored
Re-enable qtconsole in downstream checks (#1090)
PR #1089 fixed the channel cleanup and _exiting instance variable issues that were causing qtconsole test failures. Re-add qtconsole to the required downstream checks and remove the test_scroll[False] deselect.
1 parent cd14b0e commit b32dcce

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/downstream.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,9 @@ jobs:
114114

115115
- name: Test qtconsole
116116
shell: bash -l {0}
117-
# Skip flaky test_scroll[False] - times out waiting for shell prompt in CI
118117
run: |
119118
cd ${GITHUB_WORKSPACE}/../qtconsole
120-
xvfb-run --auto-servernum ${pythonLocation}/bin/python -m pytest -x -vv -s --full-trace --color=yes --deselect qtconsole/tests/test_00_console_widget.py::test_scroll[False] qtconsole
119+
xvfb-run --auto-servernum ${pythonLocation}/bin/python -m pytest -x -vv -s --full-trace --color=yes qtconsole
121120
122121
downstreams_check: # This job does nothing and is only used for the branch protection
123122
if: always()
@@ -127,7 +126,7 @@ jobs:
127126
- nbconvert
128127
- jupyter_server
129128
- jupyter_kernel_test
130-
# qtconsole removed - too flaky in CI (GUI + async kernel tests)
129+
- qtconsole
131130
runs-on: ubuntu-latest
132131
steps:
133132
- name: Decide whether the needed jobs succeeded or failed

0 commit comments

Comments
 (0)