remove non working part from action. add simple tests for now

Author: kdabir

.github/workflows/main.yml

@@ -13,8 +13,8 @@ jobs:
       - name: Run Shellcheck
         uses: ludeeus/[email protected]
 
-  unit-test-ubuntu:
-    name: unit-test (ubuntu)
+  test-ubuntu:
+    name: test (ubuntu)
     runs-on: ubuntu-latest
     steps:
       - name: Clone Repo
@@ -23,28 +23,33 @@ jobs:
         id: setup-bats
         uses: bats-core/[email protected]
       - name: Run Unit Tests
-        run: make test
+        run: make unit-test
+        shell: bash
+      - name: Run Integration Tests
+        run: make intg-test
         shell: bash
 
-  unit-test-macos:
-    name: unit-test (macos)
+  test-macos:
+    name: test (macos)
     runs-on: macos-latest
     steps:
       - name: Clone Repo
         uses: actions/checkout@v4
       - name: Install bats-core
         run: brew install bats-core
       - name: Run Unit Tests
-        run: make test
+        run: make unit-test
         shell: bash
-
-
-  intg-test:
-    name: intg-test
-    runs-on: ubuntu-latest
-    steps:
-      - name: Clone Repo
-        uses: actions/checkout@v4
-      - name: Run Integration Tests in Docker
-        run: make docker-test
+      - name: Run Integration Tests
+        run: make intg-test
         shell: bash
+
+  # intg-test:
+  #   name: intg-test
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - name: Clone Repo
+  #       uses: actions/checkout@v4
+  #     - name: Run Integration Tests in Docker
+  #       run: make docker-test
+  #       shell: bash

.hasrc

@@ -1,6 +1,12 @@
-# make to install/test the project
+# required to install/test the project
 make
 curl
 git
-# bats for testing
+# bats for testing shell script
 bats
+# for running integration tests 
+# their outputs will be tested
+sed
+awk
+jq
+node

Makefile

@@ -9,12 +9,15 @@ ifeq ($(PREFIX),)
 	PREFIX := /usr/local
 endif
 
-test : has
+
+test: unit-test intg-test
+
+unit-test:
 	bats tests/unit/unit-tests.bats
 	bats tests/unit/with-mocks.bats
 
-test-intg : has
-	bats -t tests/intg/test_all_packages.bats
+intg-test:
+	bats -t tests/intg/intg-tests.bats 
 
 has :
 	# ensure 'has' in repo
@@ -53,9 +56,9 @@ docker-test:
 
 .PHONY: docker-test-%
 docker-test-%:
-	docker build -t test-image:$* -f tests/containers/$*.Dockerfile .
+	docker build -t test-image:$* -f tests/to-fix/containers/$*.Dockerfile .
 	docker run --rm \
 		-v $(PWD):/workspace \
 		-w /workspace \
 		test-image:$* \
-		bash -c "make test || bats -t ./tests/test_all_packages.bats || true"
+		bash -c "make test || bats -t ./tests/to-fix/test_all_packages.bats || true"

tests/intg/intg-tests.bats

@@ -0,0 +1,100 @@
+#!/usr/bin/env bats
+
+## should work on mac and ubuntu
+## tests just the core features with minimum set of tools
+
+INSTALL_DIR=
+BATS_TMPDIR="${BATS_TMPDIR:-/tmp}"
+fancyx='✗'
+checkmark='✓'
+
+## We need to create a new directory so that .hasrc file in the root does not get read by the `has` instance under test
+setup() {
+  export HAS_TMPDIR="${BATS_TMPDIR}/tmp-for-test"
+  mkdir -p "${HAS_TMPDIR}"
+  cp -f "${BATS_TEST_DIRNAME}"/../../has "${HAS_TMPDIR}"
+  cd "${HAS_TMPDIR}" || return
+  export has="${HAS_TMPDIR}/has"
+}
+
+teardown() {
+  if [[ -d "${HAS_TMPDIR}" ]]; then
+    rm -rf "${HAS_TMPDIR}"
+  fi
+}
+
+@test "invoking 'has' without arguments prints usage" {
+  run $has
+
+  [ "$status" -eq 0 ]
+  [ "${lines[0]}" = 'Usage: has [OPTION] <command-names>...' ]
+  [ "${lines[1]}" = 'Has checks the presence of various command line tools on the PATH and reports their installed version.' ]
+}
+
+@test "git version output is non-empty and debug output is shown" {
+  run $has git
+  echo "Output: $output"
+  [ "$status" -eq 0 ]
+  [ "$(echo "${lines[0]}" | grep "git")" ]
+  version="${lines[0]##* }"
+  [ "${#version}" -ge 2 ]
+}
+
+@test "check multiple real tools from .hasrc (make, curl, jq, node)" {
+  run $has make curl jq node
+  echo "Output: $output"
+  [ "$status" -eq 0 ]
+  for tool in make curl jq node; do
+    line=$(echo "$output" | grep "$tool")
+    [ -n "$line" ]
+    version="${line##* }"
+    [ "${#version}" -ge 1 ]
+  done
+}
+
+@test "loads commands from .hasrc file and excludes comments (real tools, output debug)" {
+  printf "bash\n#comment\nmake\n" > .hasrc
+  run $has
+  echo "Output: $output"
+  [ "$status" -eq 0 ]
+  for tool in bash make; do
+    line=$(echo "$output" | grep "$tool")
+    [ -n "$line" ]
+    version="${line##* }"
+    [ "${#version}" -ge 1 ]
+  done
+}
+
+@test "'has' warns about tools not configured" {
+  run $has foobar
+
+  [ "$status" -eq 1 ]
+  [ "$(echo "${output}" | grep ${fancyx} | grep "foobar not understood")" ]
+}
+
+@test "env var 'HAS_ALLOW_UNSAFE' overrides safety check" {
+  HAS_ALLOW_UNSAFE=y run $has foobar
+
+  [ "$status" -eq 1 ]
+  [ "$(echo "${output}" | grep ${fancyx} | grep "foobar")" ]
+}
+
+@test "status code reflects number of failed commands" {
+  HAS_ALLOW_UNSAFE=y run $has foobar git barbaz
+
+  [ "$status" -eq 2 ]
+  [ "$(echo "${output}" | grep ${fancyx} | grep "foobar")" ]
+  [ "$(echo "${output}" | grep ${fancyx} | grep "barbaz")" ]
+}
+
+
+@test "loads commands from .hasrc file and honors CLI args as well" {
+  printf "bash\nmake\ngit" >> .hasrc
+  run $has git jq
+
+  [ "$status" -eq 0 ]
+  [ "$(echo "${output}" | grep ${checkmark} | grep "bash")" ]
+  [ "$(echo "${output}" | grep ${checkmark} | grep "make")" ]
+  [ "$(echo "${output}" | grep ${checkmark} | grep "git")"  ]
+  [ "$(echo "${output}" | grep ${checkmark} | grep "jq")"   ]
+}