kisdatabaselogfile.c: fix timestamp #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into accounts the microseconds given by the user in timestamp_start or timestamp_end thanks to the update in sqlite wrapper that supports nested queries since commit 9777115 Signed-off-by: Fabrice Fontaine <[email protected]>
Owner
|
Unfortunately I just had to disable that support in the code because of a weirdness in how GCC processed the template code vs clang. I haven't figured out what's broken, yet; once I do I'll pull this though. |
Contributor
Author
|
I think your issue is fixed since 6db35c9, so perhaps it is time to pull this PR? |
Contributor
|
I don't think the supporting code handles nested req's still; have you
gotten this to actually respond correctly?
…On Thu, May 14, 2020 at 3:34 PM Fabrice Fontaine ***@***.***> wrote:
I think your issue is fixed since 6db35c9
<6db35c9>,
so perhaps it is time to pull this PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZAOCHQ3HARZMDKR52R3PDRRRBVXANCNFSM4MYRPE7A>
.
|
Contributor
Author
|
It seemed to work the day I submitted it but I didn't retest it since that time on master. I'll do it and keep you informed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into accounts the microseconds given by the user in timestamp_start
or timestamp_end thanks to the update in sqlite wrapper that supports
nested queries since commit 9777115
Signed-off-by: Fabrice Fontaine [email protected]