✨ Print gradle output on error (#898)

Add Gradle output to errors to aid in debugging

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

Author: jmle

external-providers/java-external-provider/pkg/java_external_provider/dependency.go

@@ -482,7 +482,7 @@ func (p *javaServiceClient) getDependenciesForGradle(ctx context.Context) (map[u
 	cmd.Env = append(cmd.Env, fmt.Sprintf("JAVA_HOME=%s", javaHome))
 	output, err := cmd.CombinedOutput()
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("error trying to get Gradle dependencies: %w - Gradle output: %s", err, string(output))
 	}
 
 	lines := strings.Split(string(output), "\n")
@@ -503,6 +503,9 @@ func (c *javaServiceClient) getGradleSubprojects(ctx context.Context) ([]string,
 	}
 
 	javaHome, err := c.GetJavaHomeForGradle(ctx)
+	if err != nil {
+		return nil, err
+	}
 
 	exe, err := filepath.Abs(filepath.Join(c.config.Location, "gradlew"))
 	if err != nil {
@@ -516,7 +519,7 @@ func (c *javaServiceClient) getGradleSubprojects(ctx context.Context) ([]string,
 	cmd.Env = append(cmd.Env, fmt.Sprintf("JAVA_HOME=%s", javaHome))
 	output, err := cmd.CombinedOutput()
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("error getting gradle subprojects: %w - Gradle output: %s", err, string(output))
 	}
 
 	beginRegex := regexp.MustCompile(`Root project`)

external-providers/java-external-provider/pkg/java_external_provider/provider.go

@@ -614,7 +614,7 @@ func (s *javaServiceClient) resolveSourcesJarsForGradle(ctx context.Context, fer
 	// obtain Gradle version, needed for compatibility checks
 	gradleVersion, err := s.GetGradleVersion(ctx)
 	if err != nil {
-		gradleVersion = version.Version{}
+		return err
 	}
 
 	// append downloader task
@@ -664,7 +664,7 @@ func (s *javaServiceClient) resolveSourcesJarsForGradle(ctx context.Context, fer
 	cmd.Dir = s.config.Location
 	output, err := cmd.CombinedOutput()
 	if err != nil {
-		return err
+		return fmt.Errorf("error trying to get sources for Gradle: %w - Gradle output: %s", err, output)
 	}
 
 	s.log.V(8).WithValues("output", output).Info("got gradle output")

external-providers/java-external-provider/pkg/java_external_provider/service_client.go

@@ -490,7 +490,7 @@ func (s *javaServiceClient) GetGradleVersion(ctx context.Context) (version.Versi
 		cmd.Env = append(cmd.Env, fmt.Sprintf("JAVA_HOME=%s", os.Getenv("JAVA_HOME")))
 		output, err = cmd.CombinedOutput()
 		if err != nil {
-			return version.Version{}, err
+			return version.Version{}, fmt.Errorf("error trying to get Gradle version: %w - Gradle output: %s", err, string(output))
 		}
 	}