-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Labels
needs-kindIndicates an issue or PR lacks a `kind/foo` label and requires one.Indicates an issue or PR lacks a `kind/foo` label and requires one.needs-priorityIndicates an issue or PR lacks a `priority/foo` label and requires one.Indicates an issue or PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
Context
In PR #860, a code review identified that provider/server.go calls log.Fatalf when gs.Serve(listen) returns an error (around lines 145-147). This exits the entire process and bypasses callers' control and cleanup logic.
Problem
log.Fatalf should not be used in library code as it prevents proper error handling and cleanup by callers.
Requested Change
The function should return the error to the caller instead of calling log.Fatalf, allowing the caller to handle cleanup appropriately.
References
- PR: ✨ Adding begining of socket communication #860
- Review Comment: ✨ Adding begining of socket communication #860 (comment)
- Requested by: @shawn-hurley
Metadata
Metadata
Assignees
Labels
needs-kindIndicates an issue or PR lacks a `kind/foo` label and requires one.Indicates an issue or PR lacks a `kind/foo` label and requires one.needs-priorityIndicates an issue or PR lacks a `priority/foo` label and requires one.Indicates an issue or PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Type
Projects
Status
🆕 New