Inconsistent tackle_cr default format and content in global-ci-bundle.yml

[shawn-hurley]

Description

The tackle_cr input parameter has different default formats and content between workflow_call and workflow_dispatch triggers in global-ci-bundle.yml.

Location

.github/workflows/global-ci-bundle.yml

Details

workflow_call (lines 73-83)

Format: YAML (plain text)

kind: Tackle
apiVersion: tackle.konveyor.io/v1alpha1
metadata:
  name: tackle
spec:
  image_pull_policy: IfNotPresent
  analyzer_container_memory: 0
  analyzer_container_cpu: 0
  feature_auth_required: false
  disable_maven_search: true

workflow_dispatch (line 167)

Format: JSON (single line)

{"kind":"Tackle","apiVersion":"tackle.konveyor.io/v1alpha1","metadata":{"name":"tackle"},"spec":{"image_pull_policy":"IfNotPresent","analyzer_container_memory":0,"analyzer_container_cpu":0,"feature_auth_required":false}}

Key Differences

1. Format: YAML vs JSON
2. Missing field: The JSON version is missing disable_maven_search: true

Impact

• Different behavior between workflow calls and manual dispatches
• Maven search behavior differs: disabled in workflow_call, enabled in workflow_dispatch
• Potential confusion for users expecting consistent defaults
• The missing disable_maven_search setting could affect test performance and behavior

Recommendation

Standardize both to use the same format (prefer JSON for single-line input) and include all fields:

{"kind":"Tackle","apiVersion":"tackle.konveyor.io/v1alpha1","metadata":{"name":"tackle"},"spec":{"image_pull_policy":"IfNotPresent","analyzer_container_memory":0,"analyzer_container_cpu":0,"feature_auth_required":false,"disable_maven_search":true}}

Related Files

• .github/workflows/global-ci-bundle.yml:73-83
• .github/workflows/global-ci-bundle.yml:167