Skip to content

Inconsistent install action names and versioning between workflows #137

@shawn-hurley

Description

@shawn-hurley

Description

The install action has inconsistent naming and versioning approaches between global-ci.yml and global-ci-bundle.yml.

Locations

  • .github/workflows/global-ci.yml
  • .github/workflows/global-ci-bundle.yml

Details

global-ci.yml (version-specific, uses "install-tackle")

  • Line 243: v0.7.*konveyor/tackle2-operator/.github/actions/[email protected]
  • Line 254: v0.8.*konveyor/tackle2-operator/.github/actions/[email protected]
  • Line 265: latestkonveyor/tackle2-operator/.github/actions/install-tackle@main

global-ci-bundle.yml (always @main, uses "install-konveyor")

  • Line 350: Always uses konveyor/tackle2-operator/.github/actions/install-konveyor@main

Key Differences

  1. Action name: install-tackle vs install-konveyor
  2. Versioning strategy: Version-specific branches vs always @main

Impact

  • Confusion about which action to use and when
  • Unclear if these are the same action with different names or completely different actions
  • The naming inconsistency suggests a migration (tackle → konveyor) that's incomplete
  • Bundle workflow may not work correctly with older release versions due to always using @main

Questions

  1. Is install-konveyor a renamed version of install-tackle?
  2. If so, should global-ci.yml migrate to use install-konveyor?
  3. Should global-ci-bundle.yml support version-specific install actions?

Recommendation

  1. Standardize on a single action name (install-konveyor seems newer)
  2. Document the relationship between these actions if they're different
  3. Apply consistent versioning strategy across both workflows
  4. Consider migrating global-ci.yml to use install-konveyor with appropriate version branches

Related Files

  • .github/workflows/global-ci.yml:243-275
  • .github/workflows/global-ci-bundle.yml:350-354

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions