generated from konveyor/template-repo
-
Couldn't load subscription status.
- Fork 13
Open
Description
Description
The install action has inconsistent naming and versioning approaches between global-ci.yml and global-ci-bundle.yml.
Locations
.github/workflows/global-ci.yml.github/workflows/global-ci-bundle.yml
Details
global-ci.yml (version-specific, uses "install-tackle")
- Line 243:
v0.7.*→konveyor/tackle2-operator/.github/actions/[email protected] - Line 254:
v0.8.*→konveyor/tackle2-operator/.github/actions/[email protected] - Line 265:
latest→konveyor/tackle2-operator/.github/actions/install-tackle@main
global-ci-bundle.yml (always @main, uses "install-konveyor")
- Line 350: Always uses
konveyor/tackle2-operator/.github/actions/install-konveyor@main
Key Differences
- Action name:
install-tacklevsinstall-konveyor - Versioning strategy: Version-specific branches vs always @main
Impact
- Confusion about which action to use and when
- Unclear if these are the same action with different names or completely different actions
- The naming inconsistency suggests a migration (tackle → konveyor) that's incomplete
- Bundle workflow may not work correctly with older release versions due to always using @main
Questions
- Is
install-konveyora renamed version ofinstall-tackle? - If so, should
global-ci.ymlmigrate to useinstall-konveyor? - Should
global-ci-bundle.ymlsupport version-specific install actions?
Recommendation
- Standardize on a single action name (
install-konveyorseems newer) - Document the relationship between these actions if they're different
- Apply consistent versioning strategy across both workflows
- Consider migrating
global-ci.ymlto useinstall-konveyorwith appropriate version branches
Related Files
.github/workflows/global-ci.yml:243-275.github/workflows/global-ci-bundle.yml:350-354
Metadata
Metadata
Assignees
Labels
No labels