Address additional review comments

Signed-off-by: Nandini Chandra <[email protected]>

Author: nachandr

cypress/e2e/models/administration/source-platform/source-platform.ts

@@ -108,34 +108,40 @@ export class SourcePlatform {
     }
 
     edit(
-        updatedValues: {
-            name?: string;
-            url?: string;
-            credentials?: string;
-        },
+        updatedValues: Partial<{
+            name: string;
+            url: string;
+            credentials: string;
+        }>,
         cancel = false
     ): void {
         SourcePlatform.open();
         performRowActionByIcon(this.name, commonView.pencilAction);
 
         if (cancel) {
             cancelForm();
-        } else {
-            if (updatedValues.name && updatedValues.name !== this.name) {
-                this.fillName(updatedValues.name);
-                this.name = updatedValues.name;
-            }
-            if (updatedValues.url && updatedValues.url !== this.url) {
-                this.fillUrl(updatedValues.url);
-                this.url = updatedValues.url;
-            }
-            if (updatedValues.credentials && updatedValues.credentials !== this.credentials) {
-                this.selectCredentials(updatedValues.credentials);
-                this.credentials = updatedValues.credentials;
-            }
-            if (updatedValues) {
-                submitForm();
-            }
+            return;
+        }
+
+        const { name, url, credentials } = updatedValues;
+
+        if (name && name !== this.name) {
+            this.fillName(name);
+            this.name = name;
+        }
+
+        if (url && url !== this.url) {
+            this.fillUrl(url);
+            this.url = url;
+        }
+
+        if (credentials && credentials !== this.credentials) {
+            this.selectCredentials(credentials);
+            this.credentials = credentials;
+        }
+
+        if (Object.keys(updatedValues).length > 0) {
+            submitForm();
         }
     }
 }

cypress/e2e/tests/administration/source-platform/crud.test.ts

@@ -54,6 +54,7 @@ describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
     });
 
     it.skip("Perform CRUD Tests on Cloud Foundry Source platform", function () {
+        // TODO : Unskip tests once Infra ticket MTA-6241 is resolved
         const platform = new SourcePlatform(
             "CF-" + data.getRandomNumber(1, 200),
             "Cloud Foundry",
@@ -69,7 +70,7 @@ describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
         );
         exists(platform.name);
 
-        const newName = "CF-" + "updatedName" + data.getRandomNumber(1, 200);
+        const newName = "CF-" + "updatedName" + data.getRandomNumber(1, 500);
         platform.edit({ name: newName });
         exists(newName);
 
@@ -82,6 +83,11 @@ describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
         exists(newName);
 
         platform.delete();
+        checkSuccessAlert(
+            successAlertMessage,
+            `Success alert:Platform ${platform.name} was successfully deleted.`,
+            true
+        );
         notExists(platform.name);
     });