[RFR] Add SourcePlatform.edit() method (#1709)

* Add SourcePlatform.edit() method

Signed-off-by: Nandini Chandra <[email protected]>

* Add SourcePlatform.edit() method

Signed-off-by: Nandini Chandra <[email protected]>

* Add SourcePlatform.edit() method

Signed-off-by: Nandini Chandra <[email protected]>

* Address additional review comments

Signed-off-by: Nandini Chandra <[email protected]>

* Address additional review comments

Signed-off-by: Nandini Chandra <[email protected]>

* Address review comments

Signed-off-by: Nandini Chandra <[email protected]>

---------

Signed-off-by: Nandini Chandra <[email protected]>

Author: nachandr

cypress/e2e/models/administration/source-platform/source-platform.ts

@@ -19,6 +19,7 @@ import {
     clickByText,
     clickItemInKebabMenu,
     inputText,
+    performRowActionByIcon,
     selectFormItems,
     selectItemsPerPage,
     selectUserPerspective,
@@ -82,7 +83,7 @@ export class SourcePlatform {
 
     create(cancel = false): void {
         SourcePlatform.open();
-        cy.contains("button", "Create new platform", { timeout: 20000 })
+        cy.contains("button", "Create new platform", { timeout: 8000 })
             .should("be.visible")
             .and("not.be.disabled")
             .click();
@@ -97,12 +98,49 @@ export class SourcePlatform {
         }
     }
 
-    // TODO: Add update method and corresponding test
     delete(cancel = false): void {
         SourcePlatform.open();
         clickItemInKebabMenu(this.name, "Delete");
         if (cancel) {
             cancelForm();
         } else click(commonView.confirmButton);
     }
+
+    edit(
+        updatedValues: Partial<{
+            name: string;
+            url: string;
+            credentials: string;
+        }>,
+        cancel = false
+    ): void {
+        SourcePlatform.open();
+        performRowActionByIcon(this.name, commonView.pencilAction);
+
+        if (cancel) {
+            cancelForm();
+            return;
+        }
+
+        const { name, url, credentials } = updatedValues;
+
+        if (name && name !== this.name) {
+            this.fillName(name);
+            this.name = name;
+        }
+
+        if (url && url !== this.url) {
+            this.fillUrl(url);
+            this.url = url;
+        }
+
+        if (credentials && credentials !== this.credentials) {
+            this.selectCredentials(credentials);
+            this.credentials = credentials;
+        }
+
+        if (Object.keys(updatedValues).length > 0) {
+            submitForm();
+        }
+    }
 }

cypress/e2e/tests/administration/source-platform/crud.test.ts

@@ -16,13 +16,14 @@ limitations under the License.
 /// <reference types="cypress" />
 
 import * as data from "../../../../utils/data_utils";
-import { checkSuccessAlert, exists, login, notExists } from "../../../../utils/utils";
+import { checkSuccessAlert, deleteByList, exists, login, notExists } from "../../../../utils/utils";
 import { CredentialsSourceControlUsername } from "../../../models/administration/credentials/credentialsSourceControlUsername";
 import { SourcePlatform } from "../../../models/administration/source-platform/source-platform";
 import { CredentialType, UserCredentials } from "../../../types/constants";
 import { successAlertMessage } from "../../../views/common.view";
+import * as selectors from "../../../views/source-platform.view";
 
-let cloudFoundryCreds: CredentialsSourceControlUsername;
+let cloudFoundryCreds: Array<CredentialsSourceControlUsername> = [];
 
 describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
     before("Login", function () {
@@ -36,25 +37,30 @@ describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
         }
         login();
         cy.visit("/");
-        cloudFoundryCreds = new CredentialsSourceControlUsername(
-            data.getRandomCredentialsData(
-                CredentialType.sourceControl,
-                UserCredentials.usernamePassword,
-                false,
-                null,
-                null,
-                true
-            )
-        );
-        cloudFoundryCreds.create();
+        for (let i = 0; i < 2; i++) {
+            const creds = new CredentialsSourceControlUsername(
+                data.getRandomCredentialsData(
+                    CredentialType.sourceControl,
+                    UserCredentials.usernamePassword,
+                    false,
+                    null,
+                    null,
+                    true
+                )
+            );
+            creds.name = `CF-CREDS-${data.getRandomNumber(1, 500)}`;
+            creds.create();
+            cloudFoundryCreds.push(creds);
+        }
     });
 
-    it("Perform CRUD Tests on Cloud Foundry Source platform", function () {
+    it.skip("Perform CRUD Tests on Cloud Foundry Source platform", function () {
+        // TODO : Unskip tests once Infra ticket MTA-6241 is resolved
         const platform = new SourcePlatform(
-            "CF-" + data.getRandomNumber(1, 200),
+            `CF-${data.getRandomNumber(1, 500)}`,
             "Cloud Foundry",
             Cypress.env("cloudfoundry_url"),
-            cloudFoundryCreds.name
+            cloudFoundryCreds[0].name
         );
 
         platform.create();
@@ -65,11 +71,28 @@ describe(["@tier2"], "CRUD operations on Cloud Foundry Source platform", () => {
         );
         exists(platform.name);
 
+        const newName = `CF-updatedName-${data.getRandomNumber(1, 500)}`;
+        platform.edit({ name: newName });
+        exists(newName);
+
+        const newURL = "https://api.bosh-updated-lite.com";
+        platform.edit({ url: newURL });
+        cy.get(selectors.url).should("have.value", newURL);
+
+        const newCreds = cloudFoundryCreds[1].name;
+        platform.edit({ credentials: newCreds });
+        cy.get(selectors.credentials).should("have.value", newCreds);
+
         platform.delete();
+        checkSuccessAlert(
+            successAlertMessage,
+            `Success alert:Platform ${platform.name} was successfully deleted.`,
+            true
+        );
         notExists(platform.name);
     });
 
     after("Clear test data", function () {
-        cloudFoundryCreds.delete();
+        deleteByList(cloudFoundryCreds);
     });
 });